Github user macdonst commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103261864
  
    --- Diff: src/android/StatusBar.java ---
    @@ -164,4 +181,21 @@ private void setStatusBarBackgroundColor(final String 
colorPref) {
                 }
             }
         }
    +
    +    private void setStatusBarTransparent(final boolean transparent) {
    +        if (Build.VERSION.SDK_INT >= 21) {
    +            final Window window = cordova.getActivity().getWindow();
    +            if (transparent) {
    +                window.getDecorView().setSystemUiVisibility(
    +                        View.SYSTEM_UI_FLAG_LAYOUT_STABLE
    +                                | View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN);
    +                window.setStatusBarColor(Color.TRANSPARENT);
    --- End diff --
    
    Yeah, I hate reflection on Android too. It is junk. The reason I suggested 
following the same code style as `setStatusBarBackgroundColor` is sometimes our 
users build with older versions of the Android API. I know that's wrong but 
it's hard to stop them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to