Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/536#discussion_r109532730
--- Diff: cordova-lib/src/cordova/metadata/ubuntu_parser.js ---
@@ -109,8 +110,8 @@ ubuntu_parser.prototype.update_manifest = function() {
content += '\nIcon=qmlscene';
console.warn('missing icon element in config.xml');
}
- fs.writeFileSync(path.join(this.path, 'manifest.json'),
JSON.stringify(manifest));
- fs.writeFileSync(path.join(this.path, 'cordova.desktop'), content);
--- End diff --
Would you replace this with packageManager.save or just in cases when
JSON.stringify is used??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
