GitHub user khawkins opened a pull request:

    https://github.com/apache/cordova-ios/pull/297

    CB-12050 ios: Create shared scheme for framework target, for Carthage 
support

    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Adds a shared build scheme for the Cordova framework target of the iOS 
project, which is a prerequisite for Carthage support.
    
    ### What testing has been done on this change?
    1. Manually ran Carthage against this change, to ensure that it was able to 
download and build the framework target.
    2. Imported the resultant framework into a test iOS app (Objective-C), 
instantiated a `CDVViewController` instance, added the default configuration to 
the app (config.xml, www/index.xml), and verified that the expected view would 
load at app startup.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    **NB:** There are possibly scenarios where automated testing of Carthage 
support could be considered, but I'm not sure what that looks like at this 
point.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khawkins/cordova-ios CB-12050

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #297
    
----
commit fdc5e73b6230474d8e59d05c473065e7f23c6de6
Author: Kevin Hawkins <khawk...@salesforce.com>
Date:   2017-03-15T00:17:30Z

    CB-12050 ios: Create shared scheme for framework target, for Carthage 
support

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to