Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/107
I think the PR is ok and I don't think that we need the weakSelf in this
case. In fact, I think we are overusing it in most cases, we should only use it
when we might have a retain cycle.
The only thing that might be changed on the PR is to create the
PluginResult inside all the blocks, but just for consistency, there is one
inside and the other two outside.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
