I vote +1 - Tested <resource-file> tag functionality is copying or referencing if reference attribute is set - Tested compatibility with Visual Studio - Ran automated tests
On Thu, Feb 9, 2017 at 9:24 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com.invalid> wrote: > I vote +1 > > - Verified licenses and license headers > - Ran automates tests > - Verified archive > - Verified tag > > - > Best regards, Vladimir > > > On 2/9/17, 09:57, "alsoro...@apache.org" <alsoro...@apache.org> wrote: > > I vote +1. > > * Verified archives via `coho verify-archive` > * Verified tags manually > * Verified that blank app creates correctly with platform > * Verified that blank app can be successfully built and ran > * Verified that platform can be updated from previous version > * Verified compatibility with core plugins > * Verified release notes > * Verified version > * Verified line breaks > * Verified compatibility with Visual Studio > > -- Alexander Sorokin > > -----Original Message----- > From: dase...@apache.org [mailto:dase...@apache.org] > Sent: Wednesday, February 8, 2017 8:20 PM > To: dev@cordova.apache.org > Subject: [Vote] 5.0.0 Windows Release > > Please review and vote on this 5.0.0 Windows Release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: > https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fissues.apac > he.org%2Fjira%2Fbrowse%2FCB-12404&data=02%7C01%7Cv-alsoro% > 40microsoft.com%7C > 27147ccdfdcc4e8d12ab08d45046afec%7C72f988bf86f141af91ab2d7cd011 > db47%7C1%7C0% > 7C636221711911814136&sdata=Q%2BsHad7YDUJ7gaAe4efeD1d1ntNWQN > Z6vWPTB9otP6A%3D& > reserved=0 > > > > The archive has been published to dist/dev: > > https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fdist.apache > .org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-12404%2F&data= > 02%7C01%7Cv-alsoro%40 > microsoft.com%7C27147ccdfdcc4e8d12ab08d45046afec% > 7C72f988bf86f141af91ab2d7cd > 011db47%7C1%7C0%7C636221711911814136&sdata= > EBwPD3j4cb9idteUka7BZzpVVPgXZfkE9 > NhTnRbsuDk%3D&reserved=0 > > > > The package was published from its corresponding git tag: > > cordova-windows: 5.0.0 (75d7bcf01e) > > > > Note that you can test it out via: > > > > cordova platform add > https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.com% > 2Fapache%2Fcordova-windows%235.0.0&data=02%7C01%7Cv-alsoro% > 40microsoft.com%7 > C27147ccdfdcc4e8d12ab08d45046afec%7C72f988bf86f141af91ab2d7cd011 > db47%7C1%7C0 > %7C636221711911814136&sdata=2nyElr3rLRACU1mp%2B9CeCepjep8% > 2BTERrLaZWCZSdX%2B > 0%3D&reserved=0 > > > > Upon a successful vote I will upload the archive to dist/, publish it > to > npm, and post the blog post. > > > > Voting guidelines: > https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.com% > 2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs% > 2Frelease-voting.md&data=02%7 > C01%7Cv-alsoro%40microsoft.com%7C27147ccdfdcc4e8d12ab08d45046 > afec%7C72f988bf > 86f141af91ab2d7cd011db47%7C1%7C0%7C636221711911814136& > sdata=wZ3BZYdWUF7%2BB0 > PzVrlR%2B1dQAd0LcsL%2Bxa9nQXqY2wo%3D&reserved=0 > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > subdependencies have > Apache-compatible licenses > > * Ensured continuous build was green when repo was tagged > > * Ensured that all tests pass > > * Created, built and ran mobilespec app > > * Tested create and update scenarios via platform scripts and > cordova-cli > > > > Please let me know if you have any questions or considerations. > > > > Best regards, > > Sergey Shakhnazarov. > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > > >
