Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94508708
--- Diff: src/android/InAppBrowser.java ---
@@ -722,7 +729,57 @@ public void onClick(View v) {
inAppWebView = new WebView(cordova.getActivity());
inAppWebView.setLayoutParams(new
LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT,
LayoutParams.MATCH_PARENT));
inAppWebView.setId(Integer.valueOf(6));
- inAppWebView.setWebChromeClient(new
InAppChromeClient(thatWebView));
+ // File Chooser Implemented ChromeClient
+ inAppWebView.setWebChromeClient(new
InAppChromeClient(thatWebView) {
+ // For Android 5.0+
+ public boolean onShowFileChooser (WebView webView,
ValueCallback<Uri[]> filePathCallback, WebChromeClient.FileChooserParams
fileChooserParams)
+ {
+ Log.d(LOG_TAG, "File Chooser 5.0+");
--- End diff --
I'm going to open an issue to create an Android Style Guide or something.
I kinda feel bad we're being this nit-picky on someone's first PR. (I'm still
going to do it, because we're supposed to, but still)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
