+1 to this PR On Mon, Oct 10, 2016 at 10:38 AM, Shazron <shaz...@gmail.com> wrote:
> +1 but with caveats as I outlined in the PR. > > On Mon, Oct 10, 2016 at 10:16 AM, julio cesar sanchez < > jcesarmob...@gmail.com> wrote: > > > I was the one who asked for the email as I think we should discuss it > > before merging. > > > > I agree with Fares idea, if the height or width are greater than the > > originals then I think we shouldn't upscale the image and return the > > original image instead. > > But that should be documented (current PR doesn't document it). > > > > So +1 for the PR. > > > > > > > > 2016-10-10 11:34 GMT+02:00 Fares de Marki <fa...@markiapp.com>: > > > > > Hi, > > > > > > I sent a pull request for the cordova camera plugin : > > > https://github.com/apache/cordova-plugin-camera/pull/238 > > > > > > I was asked to send you an email. > > > This pull request prevents the plugin from creating bigger pictures > than > > > original ones. > > > > > > Thanks > > > > > > > > > Fares Hantous > > > Marki > > > http://markiapp.com/ <http://markiapp.com/> > > > > > > > > > > > > > > >
