Good work guys!
On Tue, Oct 18, 2016 at 3:30 PM, Darryl Pogue <dvpdin...@gmail.com> wrote: > I've opened a PR to add that bridge mode: > https://github.com/crosswalk-project/cordova-plugin- > crosswalk-webview/pull/100 > > On 18 October 2016 at 15:23, Joe Bowser <bows...@gmail.com> wrote: > > BTW: I'd send a PR, but I still need Crosswalk to take over the repo from > > me, since they're developing off a fork of my repo. > > > > https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview > > > > > > > > On Tue, Oct 18, 2016 at 3:08 PM, Joe Bowser <bows...@gmail.com> wrote: > > > >> Hey > >> > >> I just realized what the problem is: > >> > >> Crosswalk is missing this method, which adds the bridge mode, since the > >> bridge mode defaults back ONLINE_EVENT in the event that EVAL_BRIDGE > isn't > >> supported, this will break every time. We need the following line > added to > >> Crosswalk. > >> > >> nativeToJsMessageQueue.addBridgeMode(new > >> NativeToJsMessageQueue.EvalBridgeMode(this, > cordova)); > >> > >> > >> On Tue, Oct 18, 2016 at 2:32 PM, Joe Bowser <bows...@gmail.com> wrote: > >> > >>> Correct. Without that method, it won't even compile. > >>> > >>> > >>> On Tue, Oct 18, 2016 at 2:31 PM, Darryl Pogue <dvpdin...@gmail.com> > >>> wrote: > >>> > >>>> On 18 October 2016 at 14:24, Joe Bowser <bows...@gmail.com> wrote: > >>>> > Recently, we decided to change the default bridge from using > >>>> OnlineEvent to > >>>> > a JS_Exec bridge so that we can support a multi-webview use case. > The > >>>> > downside of this change is that it breaks on Crosswalk. It's almost > >>>> > impossible to debug this since projects that include the Crosswalk > >>>> Webview > >>>> > break Android Studio. > >>>> > >>>> Just confirming, this is breaking on the latest version of Crosswalk > >>>> (2.1.0) that has the evaluateJavascript method added to the > >>>> XWalkWebViewEngine class? > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >>>> For additional commands, e-mail: dev-h...@cordova.apache.org > >>>> > >>>> > >>> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
