Github user vladimir-kotikov commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-inappbrowser/pull/178#discussion_r75115134
  
    --- Diff: src/windows/InAppBrowserProxy.js ---
    @@ -176,6 +179,38 @@ var IAB = {
     
                     browserWrap.appendChild(popup);
     
    +                var closeHandler = function (e) {
    +                    setTimeout(function () {
    +                        IAB.close(navigationEventsCallback);
    +                    }, 0);
    +                };
    +
    +                if (features.indexOf("hardwareback=yes") > -1 || 
features.indexOf("hardwareback") === -1) {
    +                    hardwareBackCallback = function () {
    +                        if (browserWrap.style.display === 'none') {
    +                            // NOTE: On Windows Phone 8.1 backbutton 
handlers have to throw an exception in order to exit the app
    +                            throw 'Exit the app';
    --- End diff --
    
    From what i understand, this doesn't necessarily mean that app will exit 
after this - this just means that app will fall back to default system 
navigation behavior. If that's true please update comment above to reflect this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to