GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/185
CB-11558 Make windows plugin rm remove ProjectReference items
The issue was that we have been passing a relative path during
`JsprojManager`.`addProjectReference` and an absolute path during
`JsprojManager`.`removeProjectReference` so that regexp failed to find and
remove it.
The tests were passing as they were also using absolute paths to the dummy
plugin (it was not being added to the test project at all).
Initial idea was to use relative paths instead for project sharing:
[CB-10927 Framework references in plugin.xml file prevent Windows Universal
projects from being used on other
machines](https://issues.apache.org/jira/browse/CB-10927)
Also updated the tests to use relative paths to the ProjectReferences.
[Jira issue](https://issues.apache.org/jira/browse/CB-11558)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-windows CB-11558
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #185
----
commit ee570036bc8faddc7d63e2830144c3d007d8e904
Author: daserge <v-ses...@microsoft.com>
Date: 2016-07-12T11:12:48Z
CB-11558 Make windows plugin rm remove ProjectReference items
Also update the tests to use relative paths to the ProjectReferences
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
