Github user jasongin commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/182#discussion_r64836116
  
    --- Diff: tests/tests.js ---
    @@ -3441,6 +3441,27 @@ exports.defineAutoTests = function () {
                     }
                 });
             });
    +        describe('resolveLocalFileSystemURL on cdvfile://', function () {
    +            it("file.spec.147 should be able to resolve cdvfile 
applicationDirectory fs root", function(done) {
    +                var cdvfileApplicationDirectoryFsRootName;
    +                if (cordova.platformId === 'android') {
    +                    cdvfileApplicationDirectoryFsRootName = 'assets';
    +                } else if (cordova.platformId === 'ios') {
    +                    cdvfileApplicationDirectoryFsRootName = 'bundle';
    +                } else {
    --- End diff --
    
    Should we consider using the same root name all platforms to represent the 
application root installation directory? Otherwise developers are going to have 
to use similar if-else conditions in their code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to