Alright, I ended up just doing a rebase from master instead of cherry-picking. I think it should be all good now. Third vote sent.
On Fri, Feb 26, 2016 at 9:00 AM, Steven Gill <stevengil...@gmail.com> wrote: > Hmm. Alright. I thought I got them all but obviously not. I'll > reinvestigate today. > On Feb 26, 2016 3:58 AM, "Alexander Sorokin (Akvelon)" < > v-als...@microsoft.com> wrote: > >> Sorry to say that but it looks like only a half of the changes made it to >> the archive this time. >> >> Here's what is missing: >> * CB-10138 Adds missing plugin metadata to `plugin_list` module. >> * CB-10443 Pass original options instead of remaining >> * CB-10443 Fix `this.root` null reference >> * CB-10421 Fixes exception when calling run script with `--help` option >> * updated `.gitignore` >> * CB-10406 Fixes an exception, thrown when building using Ant. >> * CB-10157 Uninstall app from device/emulator only when signed apk is >> already installed >> >> -----Original Message----- >> From: Steven Gill [mailto:stevengil...@gmail.com] >> Sent: Thursday, February 25, 2016 6:45 PM >> To: dev@cordova.apache.org >> Subject: RE: [DISCUSS] Cordova-Android 5.2.0 Release >> >> Ahh your right. Looks like since 5.1.x existed I needed to manually >> cherry-pick changes into it instead of relying on coho prepare-release >> command. I'll send a new vote today. >> On Feb 25, 2016 6:19 AM, "Alexander Sorokin (Akvelon)" < >> v-als...@microsoft.com> wrote: >> >> > I think there's something wrong with the package: it doesn't contain >> > any of the changes described in the release notes, only increased >> version. >> > >> > -----Original Message----- >> > From: Steven Gill [mailto:stevengil...@gmail.com] >> > Sent: Thursday, February 25, 2016 5:59 AM >> > To: dev@cordova.apache.org >> > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release >> > >> > I added them today :D >> > >> > On Wed, Feb 24, 2016 at 6:39 PM, Nikhil Khandelwal >> > <nikhi...@microsoft.com >> > > >> > wrote: >> > >> > > These commands look great - it will be good to add them to release >> > > process docs if they are not already there. >> > > >> > > -Nikhil >> > > >> > > -----Original Message----- >> > > From: Steven Gill [mailto:stevengil...@gmail.com] >> > > Sent: Wednesday, February 24, 2016 10:03 AM >> > > To: dev@cordova.apache.org >> > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release >> > > >> > > Definitely. Already committed the update. >> > > >> > > My new strategy with bundled/checked in dependencies >> > > >> > > * update package.json dep version if required >> > > * rm -rf node_modules >> > > * npm install --production (skips dev dependencies) >> > > * git add node_modules/* (checkin all modules needed for platform >> > > add git >> > > url) >> > > * git commit >> > > * npm install (Readd dev dependencies for ability to run tests >> > > locally) >> > > >> > > >> > > >> > > On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) < >> > > v-vlk...@microsoft.com> wrote: >> > > >> > > > Steve, do you plan to update bundled `cordova-common` as a part of >> > > > this release? >> > > > >> > > > - >> > > > Best regards, Vladimir >> > > > >> > > > -----Original Message----- >> > > > From: Steven Gill [mailto:stevengil...@gmail.com] >> > > > Sent: Wednesday, February 24, 2016 8:12 PM >> > > > To: dev@cordova.apache.org >> > > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release >> > > > >> > > > Issue: >> > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fi >> > > > ss >> > > > ue >> > > > s.apache.org%2fjira%2fbrowse%2fCB-10687&data=01%7c01%7cv-vlkoti%40 >> > > > 06 >> > > > 4d >> > > > .mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86 >> > > > f1 >> > > > 41 >> > > > af91ab2d7cd011db47%7c1&sdata=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRY >> > > > xX >> > > > dH >> > > > fE%3d >> > > > >> > > > I'm going to make this version 5.1.1. I'll update here if I decide >> > > > to go with 5.2.0 instead. >> > > > >> > > > On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser <bows...@gmail.com> >> > wrote: >> > > > >> > > > > OK, are we sure we didn't add any new minor features? >> > > > > >> > > > > On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill >> > > > > <stevengil...@gmail.com> >> > > > > wrote: >> > > > > >> > > > > > Well we should be following semver. >> > > > > > >> > > > > > >> > > > > > - Bug fixes and other minor changes: Patch release, >> > > > > > increment the >> > > > last >> > > > > > number, e.g. 1.0.1 >> > > > > > - New features which don't break existing features: Minor >> > release, >> > > > > > increment the middle number, e.g. 1.1.0 >> > > > > > - Changes which break backwards compatibility: Major >> > > > > > release, >> > > > > increment >> > > > > > the first number, e.g. 2.0.0 >> > > > > > >> > > > > > >> > > > > > On Wed, Feb 17, 2016 at 9:09 AM, Carlos Santana >> > > > > > <csantan...@gmail.com> >> > > > > > wrote: >> > > > > > >> > > > > > > +1 to wait for cordova-common, then to platforms >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > On Tue, Feb 16, 2016 at 7:48 PM Steven Gill >> > > > > > > <stevengil...@gmail.com> >> > > > > > > wrote: >> > > > > > > >> > > > > > > > Any issues with me starting this release? >> > > > > > > > >> > > > > > > > I think I will wait for the cordova-common release to >> > > > > > > > finish so I can bundle it in. >> > > > > > > > >> > > > > > > > Changes: >> > > > > > > > * CB-10510: Add an optional timeout to emu start script >> > > > > > > > * CB-10498: Resume event should be sticky if it has a >> > > > > > > > plugin result >> > > > > > > > * fix HtmlNotFoundTest so that it passes when file not >> > > > > > > > found is >> > > > > handled >> > > > > > > > correctly This Closes #256 >> > > > > > > > * CB-10472 NullPointerException: >> > > > > > > > org.apache.cordova.PluginManager.onSaveInstanceState check >> > > > > > > > if >> > > > > > > pluginManager >> > > > > > > > is null before using it This closes #255 >> > > > > > > > * CB-10138 Adds missing plugin metadata to plugin_list >> module. >> > > > > > > > This >> > > > > > > closes >> > > > > > > > #254 >> > > > > > > > * CB-10443 Pass original options instead of remaining >> > > > > > > > * CB-10443 Fix `this.root` null reference >> > > > > > > > * CB-10421 Fixes exception when calling run script with >> > > > > > > > --help option >> > > > > > > > * updated .gitignore >> > > > > > > > * CB-10406 Fixes an exception, thrown when building using >> Ant. >> > > > > > > > This >> > > > > > > closes >> > > > > > > > #250 >> > > > > > > > * CB-10157 Uninstall app from device/emulator only when >> > > > > > > > signed apk is already installed >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > -------------------------------------------------------------------- >> > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> > > For additional commands, e-mail: dev-h...@cordova.apache.org >> > > >> > >> >
