Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/135#discussion_r41170122
  
    --- Diff: src/android/FileUtils.java ---
    @@ -65,9 +69,27 @@ Licensed to the Apache Software Foundation (ASF) under 
one
         public static int TYPE_MISMATCH_ERR = 11;
         public static int PATH_EXISTS_ERR = 12;
     
    +    /*
    +     * Permission callback codes
    +     */
    +
    +    public static final int READ_PERM = 0;
    +    public static final int WRITE_PERM = 1;
    +
         public static int UNKNOWN_ERR = 1000;
         
         private boolean configured = false;
    +    private String lastRawArgs;
    +
    +    private CallbackContext callback;
    +
    +    /*
    +     * We need both read and write when accessing the storage, I think.
    +     */
    +
    +    private String [] permissions = {
    --- End diff --
    
    this is unused - why not just remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to