On Tue, Sep 22, 2015 at 1:30 PM, Karen Tran <ktop...@gmail.com> wrote:
> Hi Joe, > > I tested your geolocation plugin changes with mobilespec and the app > crashes when you click "Deny" permission and when you click "Accept" > permission for the first time. When you go back to the app after accepting, > you can get location data. > I'm not getting that behaviour with the latest version of the smores branch and the latest plugin. I noticed that the watch commands aren't working as they should, which is bad. Try pulling down the latest on the smores repo. Also, please update the issue on JIRA. https://issues.apache.org/jira/browse/CB-9105 > > I agree with having a 5.0.x branch soon since I know some people are > already asking about using API 23 and needing to test it asap. > > Yeah, it's easier to get people to test off that than some random topic branch on Github. > > On Mon, Sep 21, 2015 at 9:32 PM, Joe Bowser <bows...@gmail.com> wrote: > > > On Mon, Sep 21, 2015 at 5:43 PM Nikhil Khandelwal < > nikhi...@microsoft.com> > > wrote: > > > > > Can you explain why latest plugins will not be compatible with older > > > versions of Cordova? > > > > > > They won't be compatible because Cordova-Android compiles against API 22, > > and these plugins will require API 23 so that they can detect permissions > > and support Marshmellow. > > > > > > > Can this be avoided by any means? > > > > > > Only with a lot of Java reflection, and I'd rather not subject plugin > > developers to that, or try to hide it under the hood in some awful > utility > > class that everyone will want to see die. I'm very much a fan of if > > statements because they work, and they're easy to read and debug, unlike > > when bad things happen to things you reflect into. Plugins that require > > API 23 will only work with Cordova-Android 5.0 and up. This only impacts > > five of our core plugins, but any plugin that requires permissions from > the > > Android Manifest will have to be updated. If we can avoid using advanced > > language tricks to make the APKs compatible, we should do that. > > > > When you mean they would not be compatible - will it result in a build or > > > runtime failure? > > > > > > > > This will be a build failure, since API 22 does not have these > permissions, > > nor does it have the code required for API 23. > > > > > > > For marshmallow, what is the guidance that we need to issue to the > larger > > > Cordova plugin ecosystem? Joe you are ahead of the curve here compared > to > > > most other plugin developers - a blot post explaining what are known > > > gotchas would be great. I really hope we can use our Cordova blog to > > > communicate these changes actively to the plugin ecosystem. This > mailing > > > list only gets 400+ subscribers. > > > > > > > > There will be a blog post once 5.0 is released. We're not forcing people > > to upgrade to 5.0, and we will be supporting the 4.x branch for six > > months. This does mean we're stuck supporting 3.x, 4.x and 5.x for a > brief > > window, but I have no control over when Marshmallow is released, only > > whether we want to support it or not. I think we do, but I could be > wrong. > > > > At least this should be easier than the jump from 3.x to 4.x for most > > people, but the alternative is that your plugin just doesn't work at all > on > > Marshmallow. We need to at least give plugin developers this option, > since > > it'll roll out on all the Nexus devices in the next two weeks, and we'll > > hear more about it. > > > > > > > Can you re-base your cordova-android over the current master? It's hard > > to > > > see a diff in the current form: > > > > > > https://github.com/apache/cordova-android/compare/master...infil00p:smores > > > > > > > > I had to do a merge commit to get this to happen (boo), but it should be > > mostly cleaned up now. It seems some style cleanup creeped into the most > > recent changes, but this should be a bit more readable. > > > > > > > -Nikhil > > > > > > -----Original Message----- > > > From: Joe Bowser [mailto:bows...@gmail.com] > > > Sent: Monday, September 21, 2015 2:14 PM > > > To: dev <dev@cordova.apache.org> > > > Subject: [Android] 5.0.x release branch? > > > > > > Hey > > > > > > In the next two weeks, Marshmallow will most likely getting released > with > > > the brand new Nexus 6P being released from Huawei. Given that most of > > the > > > Nexus devices will be getting this release, we should probably release > > the > > > 5.0.x branch of Android soon, and get the new plugins updated. > > > > > > It should be noted that the latest plugins will not be compatible with > > > older versions of Cordova, which is a big deal. This is due to the use > > of > > > various compatibility checks to make sure they support Marshmallow and > > > older versions of Android. > > > > > > So, if everyone can look over the smores branches of my GitHub before I > > > create the 5.0.x branch and pull the changes into it, that would be > > awesome. > > > > > > > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2finfil00p%2fcordova-android%2ftree%2fsmores&data=01%7c01%7cnikhilkh%40microsoft.com%7c1785194b1f82494fc2d908d2c2c99f36%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=%2fPKmL8KTsz5dnC3A75yMatXLQUnfK0Nv07%2bve4PVcCE%3d > > > > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2finfil00p%2fcordova-plugin-geolocation%2ftree%2fsmores&data=01%7c01%7cnikhilkh%40microsoft.com%7c1785194b1f82494fc2d908d2c2c99f36%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=o6cLXM4f3kpUGCTlIv65ft8lKv6pc5qbeY%2bdUxiP4bc%3d > > > > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2finfil00p%2fcordova-plugin-camera%2ftree%2fsmores&data=01%7c01%7cnikhilkh%40microsoft.com%7c1785194b1f82494fc2d908d2c2c99f36%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=kNsHIv6Uw2ITcT1ABmNq1JCmPTSigCGRb4zWC8maWpE%3d > > > > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2finfil00p%2fcordova-plugin-contacts%2ftree%2fsmores&data=01%7c01%7cnikhilkh%40microsoft.com%7c1785194b1f82494fc2d908d2c2c99f36%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=rZ%2f1AALPAtUwgSXyOL1uk1b0Y%2feEmqLOdU%2fwua2TbLU%3d > > > > > > Work on audio is still outstanding, BUT for some reason Audio broke > > > recently on both Lollipop and Marshmallow. I didn't test it out on > > KitKat > > > or Jellybean yet, but I'm wondering whether we should keep maintaining > > this > > > or support the standard HTML5 audio and deal with the asset issue > somehow > > > (which isn't straight forward). > > > > > > I hopefully want to get a 5.0.x branch happening this week if we can. > > > > > > What do people think? > > > > > > Joe > > > > > >
