Github user sgrebnov commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-file-transfer/pull/74#discussion_r29086624
  
    --- Diff: src/wp/FileTransfer.cs ---
    @@ -210,6 +216,80 @@ public FileTransferProgress(long bTotal = 0, long 
bLoaded = 0)
             }
     
             /// <summary>
    +        /// Helper method to copy all relevant cookies from the WebBrowser 
control into a header on
    +        /// the HttpWebRequest
    +        /// </summary>
    +        /// <param name="browser">The source browser to copy the cookies 
from</param>
    +        /// <param name="webRequest">The destination HttpWebRequest to add 
the cookie header to</param>
    +        /// <returns>Nothing</returns>
    +        private async Task CopyCookiesFromWebBrowser(HttpWebRequest 
webRequest)
    +        {
    +            var tcs = new TaskCompletionSource<object>();
    +
    +            // Accessing WebBrowser needs to happen on the UI thread
    +            Deployment.Current.Dispatcher.BeginInvoke(() =>
    --- End diff --
    
    I think we can use Invoke() instead of BeginInvoke() here so we don't need 
to additionally use TaskCompletionSource.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to