Github user mmrko commented on the pull request:

    https://github.com/apache/cordova-docs/pull/276#issuecomment-88833458
  
    > Actually, that is a bug. If 'default' is specified in config.xml, it 
should produce plist values to support both landscape and portrait.
    
    I think this is more about the semantics of `default`. IMO the `default` 
orientation translates to: _let the platform decide how to handle the 
orientation, that is, fall back to whatever is the platform's default behaviour 
by removing the corresponding orientation and supported orientation entries 
from the platform's manifest._
    
    This approach of course has, as @nikhilkh pointed out, the downside that 
one can not explicitly set the orientation to support both portrait and 
landscape via `config.xml`.
    
    Thus, to add flexibility and to address the inherent confusion around 
orientation `default` I'd suggest adding support for `supported-orientations` 
preference to `config.xml` — something that apache/cordova-lib#128 
would've also benefited from. This would allow to work around the 
aforementioned iOS issue like so:
    
    ```js
    <preference name="orientation" value="default" />
    
    <platform name="ios">
        <preference name="supported-orientations" value="portrait, landscape" />
    </platform>
    ```
    
    If this is something you feel would make sense I'd be happy to create a PR 
for the changes over at 
[apache/cordova-lib](https://github.com/apache/cordova-lib).
    
    Ping @agrieve 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to