Some devices have had a flicker issue, not sure which it was.
Joe might remember.

@purplecabbage
risingj.com

On Mon, Mar 30, 2015 at 6:17 PM, AlexTalis <g...@git.apache.org> wrote:

> Github user AlexTalis commented on a diff in the pull request:
>
>
> https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27446641
>
>     --- Diff: src/android/SplashScreen.java ---
>     @@ -194,9 +263,25 @@ public void run() {
>                      // TODO: Use the background color of the webView's
> parent instead of using the
>                      // preference.
>
>  root.setBackgroundColor(preferences.getInteger("backgroundColor",
> Color.BLACK));
>     +
>                      root.setLayoutParams(new
> LinearLayout.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT,
>                              ViewGroup.LayoutParams.MATCH_PARENT, 0.0F));
>     -                root.setBackgroundResource(drawableId);
>     +
>     +                // Use an ImageView to render the image because of
> its flexible scaling options.
>     +                splashImageView = new ImageView(context);
>     +                splashImageView.setImageResource(drawableId);
>     --- End diff --
>
>     Do you know of any other reason for setting this background color? If
> not, then I think we can take out Linear Layout.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Reply via email to