* Confirmed sigs & hashes with `coho verify-archive`
* Verified sha1s match tags with `coho verify-tags`
When checking actual contents, Looks like the released candidate has a file
that doesn't exist in the repo:
$ diff -r rc package
Only in rc/src/plugman: defaults.json
Contents of the file:
{"id":"org.apache.cordova.vibration","version":"0.3.14-dev","description":"Cordova
Vibration Plugin","license":"Apache
2.0","keywords":["cordova","vibration","ecosystem:cordova","cordova-firefoxos","cordova-wp7","cordova-wp8","cordova-android","cordova-amazon-fireos","cordova-ubuntu","cordova-ios","cordova-blackberry10","cordova-tizen"],"repository":"
https://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration.git
","bugs":"https://issues.apache.org/jira/browse/CB/component/12320639
","engines":[],"platforms":["firefoxos","wp7","wp8","android","amazon-fireos","ubuntu","ios","blackberry10","tizen"]}
Looks like it's created by:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/createpackagejson.js#L43
(which is also returning a fulfilled promise?)
Seems it's something we should fix up (shouldn't write to source
directory), but probably it's not a real problem?
On Sat, Feb 28, 2015 at 12:24 AM, Mefire O. <ommen...@microsoft.com> wrote:
> Thinking about it further, I do agree these are non-blocking.
> Sorry for delaying the process.
>
> I vote +1.
>
> Thanks,
> Mefire
>
> -----Original Message-----
> From: Parashuram N (MS OPEN TECH) [mailto:panar...@microsoft.com]
> Sent: Friday, February 27, 2015 9:11 PM
> To: dev@cordova.apache.org
> Subject: RE: [Vote] Tools Release February 27, 2015
>
> Agree with Gorkem, I think these bugs are non-blocking. I don't think we
> should block the release for this - this only impacts certain plugins, when
> using the --save feature. I think it may make sense to do a patch release,
> if we don't want to block this release.
>
> -----Original Message-----
> From: Gorkem Ercan [mailto:gorkem.er...@gmail.com]
> Sent: Friday, February 27, 2015 8:53 PM
> To: dev@cordova.apache.org
> Subject: Re: [Vote] Tools Release February 27, 2015
>
>
>
> On 27 Feb 2015, at 22:19, Mefire O. wrote:
>
> > I've spent some time testing, found two bugs and I vote -1 until we
> > address those :
> > - https://issues.apache.org/jira/browse/CB-8577
>
> I do not think this is a show stopper, probably not even a bug, I have not
> had time to change the old <feature> tags. Actually, it will make the
> migration harder if we fix it now.
>
> > - https://issues.apache.org/jira/browse/CB-8578
> No idea about this one. I am still trying to figure out why this feature
> even exists.
>
> >
> > I should be able to send pull requests to fix them shortly.
> >
> > Thanks,
> > Mefire
> >
> > -----Original Message-----
> > From: Mefire O. [mailto:ommen...@microsoft.com]
> > Sent: Friday, February 27, 2015 3:53 PM
> > To: dev@cordova.apache.org
> > Subject: RE: [Vote] Tools Release February 27, 2015
> >
> > Steven, Thanks for initiating this.
> > I'll be performing some tests/checks and will then cast my vote
> > accordingly.
> >
> > Thanks,
> > Mefire
> >
> > -----Original Message-----
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Friday, February 27, 2015 1:21 PM
> > To: dev@cordova.apache.org
> > Subject: [Vote] Tools Release February 27, 2015
> >
> > Please review and vote on this Tools Release.
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-8555
> >
> > All the tools have been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
> >
> > All the tools have also been published to npm under the rc tag.
> > Feel free to test them with npm install -g cordova@rc
> >
> > The packages were published from their corresponding git tags:
> >
> > cordova-js: 3.8.0 (5934b1b744)
> > cordova-lib: 4.3.0 (c4fbb6a3e1)
> > cordova-plugman: 0.23.0 (6ec4d1d006)
> > cordova-cli: 4.3.0 (f0fed4ad5c)
> >
> >
> > Upon a successful vote I will upload the archives to dist/, publish
> > them to NPM, and post the corresponding blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> > .md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ran npm test and built a hello world android cordova project with
> > device plugin
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>
