+1
Verified file-transfer plugin fix
Some Ad-hoc testing on windows and wp8




> On Feb 12, 2015, at 6:03 PM, Andrew Grieve <agri...@chromium.org> wrote:
> 
> c'mon..... one more....
> 
> On Thu, Feb 12, 2015 at 10:59 AM, Andrew Grieve <agri...@chromium.org>
> wrote:
> 
>> Just tried deleting device & file-transfer tags and then re-pushing them.
>> Hopefully that will kick github...
>> 
>> On Thu, Feb 12, 2015 at 8:58 AM, Ian Clelland <iclell...@chromium.org>
>> wrote:
>> 
>>> That's odd -- in the Apache repo, the tags appear to be correct (and they
>>> are on my local repos as well) -- GitHub is the only place I see that bad
>>> tag.
>>> 
>>> GitHub also does have the correct commits (4330db8 and 1882bfb) as well,
>>> but the r0.3.0 tag isn't applied to the commit in -device.
>>> 
>>> What I really don't get is that, for file-transfer, *both* commits appear
>>> to have the r0.5.0 tag!
>>> https://github.com/apache/cordova-plugin-file-transfer/commit/1882bfb
>>> https://github.com/apache/cordova-plugin-file-transfer/commit/1559888
>>> 
>>> In any case, GitHub isn't authoritative for Apache projects; the apache
>>> repo is, but this is something that we should fix if we can.
>>> 
>>> On Thu, Feb 12, 2015 at 3:51 AM, Alexander Sorokin (Akvelon) <
>>> v-als...@microsoft.com> wrote:
>>> 
>>>> Hi all,
>>>> 
>>>> I can confirm that the file transfer bug is fixed in this one, though I
>>>> see another issue here: the tags for `device` and `file transfer`
>>> plugins
>>>> are not matching the actual GitHub tags. The file transfer one is just
>>> not
>>>> updated from previous release attempt, but the device one did not match
>>> in
>>>> previous attempt either.
>>>> 
>>>> I don't think that's critical, just wanted to let you know.
>>>> 
>>>>>  cordova-plugin-device: 0.3.0 (4330db87b9)
>>>> actual tag on github for 0.3.0 is: 3a490a3
>>>> 
>>>>>  cordova-plugin-file-transfer: 0.5.0 (1882bfbd2d)
>>>> actual tag on github for 0.5.0 is: 1559888
>>>> 
>>>> Thanks,
>>>> Alexander Sorokin
>>>> 
>>>> -----Original Message-----
>>>> From: agri...@google.com [mailto:agri...@google.com] On Behalf Of
>>> Andrew
>>>> Grieve
>>>> Sent: Wednesday, February 11, 2015 17:42
>>>> To: Andrew Grieve
>>>> Cc: dev
>>>> Subject: Re: [VOTE] Plugins Release
>>>> 
>>>> Just checked - link is working again. Please cast some votes :)
>>>> 
>>>> On Mon, Feb 9, 2015 at 1:55 PM, Andrew Grieve <agri...@chromium.org>
>>>> wrote:
>>>> 
>>>>> I can't even "svn up" on it right now. Think it's just having an
>>> outage.
>>>>> 
>>>>> On Mon, Feb 9, 2015 at 11:19 AM, Alexander Sorokin (Akvelon) <
>>>>> v-als...@microsoft.com> wrote:
>>>>> 
>>>>>> Hi guys,
>>>>>> 
>>>>>> It looks like there is something wrong with access rules or
>>> something.
>>>>>> I cannot access
>>>>>> https://dist.apache.org/repos/dist/dev/cordova/CB-8429/
>>>>>> It says: 403 Forbidden
>>>>>> Can someone open access to it?
>>>>>> 
>>>>>> Thanks,
>>>>>> Alexander Sorokin
>>>>>> 
>>>>>> -----Original Message-----
>>>>>> From: agri...@google.com [mailto:agri...@google.com] On Behalf Of
>>>>>> Andrew Grieve
>>>>>> Sent: Monday, February 9, 2015 18:05
>>>>>> To: dev
>>>>>> Subject: [VOTE] Plugins Release
>>>>>> 
>>>>>> Please review and vote on the release of this plugins release.
>>>>>> 
>>>>>> Release issue: https://issues.apache.org/jira/browse/CB-8429
>>>>>> (contains release notes for all plugins)
>>>>>> 
>>>>>> The plugins have been published to dist/dev:
>>>>>> https://dist.apache.org/repos/dist/dev/cordova/CB-8429/
>>>>>> 
>>>>>> They are the same as last week except for file-transfer.
>>>>>> 
>>>>>> The packages were published from their corresponding git tags:
>>>>>> 
>>>>>>   cordova-plugin-battery-status: 0.2.12 (ec59ef11a5)
>>>>>>   cordova-plugin-camera: 0.3.5 (799ed580d3)
>>>>>>   cordova-plugin-console: 0.2.13 (7507b29527)
>>>>>>   cordova-plugin-contacts: 0.2.16 (95d4d176f3)
>>>>>>   cordova-plugin-device-motion: 0.2.11 (110b27671f)
>>>>>>   cordova-plugin-device-orientation: 0.3.11 (d8fd79b2ae)
>>>>>>   cordova-plugin-device: 0.3.0 (4330db87b9)
>>>>>>   cordova-plugin-dialogs: 0.3.0 (d12008f9cd)
>>>>>>   cordova-plugin-file-transfer: 0.5.0 (1882bfbd2d)
>>>>>>   cordova-plugin-file: 1.3.3 (b05bcff378)
>>>>>>   cordova-plugin-geolocation: 0.3.12 (ccab812a49)
>>>>>>   cordova-plugin-globalization: 0.3.4 (6b1e88d534)
>>>>>>   cordova-plugin-inappbrowser: 0.6.0 (90d41e87ce)
>>>>>>   cordova-plugin-media: 0.2.16 (10df21dea8)
>>>>>>   cordova-plugin-media-capture: 0.3.6 (cc779375e3)
>>>>>>   cordova-plugin-network-information: 0.2.15 (81037e29cf)
>>>>>>   cordova-plugin-splashscreen: 1.0.0 (a9f0faa499)
>>>>>>   cordova-plugin-vibration: 0.3.13 (25217db403)
>>>>>>   cordova-plugin-statusbar: 0.1.10 (5feffc9314)
>>>>>>   cordova-plugins: file-system-roots-0.1.0 (be0a4c6cfb)
>>>>>>   cordova-plugin-test-framework: 0.0.1 (6aad294699)
>>>>>> 
>>>>>> 
>>>>>> Upon a successful vote I will upload the archives to dist/, upload
>>>>>> them to the Plugins Registry, and post the corresponding blog post.
>>>>>> 
>>>>>> Voting guidelines:
>>> https://github.com/apache/cordova-coho/blob/master/docs/release-votin
>>>>>> g.md
>>>>>> 
>>>>>> Voting will go on for a minimum of 24 hours.
>>>>>> 
>>>>>> I vote +1:
>>>>>> 
>>>>>> * Ran coho audit-license-headers over the relevant repos
>>>>>> * Ran coho check-license to ensure all dependencies and
>>>>>> subdependencies have Apache-compatible licenses
>>>>>> * Ran mobile-spec on android, and made sure it compiled for iOS.
>>>>>> There were only 2 failures in media, and I verified that the same 2
>>>>>> errors happen with the previous plugin version
>> 
>> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to