Took care of concerns and merged into master. On Tue, Feb 10, 2015 at 11:12 AM, Steven Gill <stevengil...@gmail.com> wrote:
> Appreciate the feedback! > > At nodesummit today and tomorrow. Will try to find some time to respond. > On Feb 9, 2015 2:46 PM, "Michal Mocny" <mmo...@chromium.org> wrote: > >> (I commented on the other thread) >> >> Left comments inline, but haven't tested. Overall, looks good and I like >> the approach! >> >> On Mon, Feb 9, 2015 at 10:35 AM, Andrew Grieve <agri...@chromium.org> >> wrote: >> >> > Plan sounds good to me! >> > >> > On Fri, Feb 6, 2015 at 7:11 PM, Steven Gill <stevengil...@gmail.com> >> > wrote: >> > >> > > Hey All! Figured this should get its own thread >> > > >> > > So createpackagejson script is done. I have it all on branch CB-8416. >> > > >> > > USAGE: plugman createpackagejson PLUGIN_PATH >> > > >> > > Commit: >> > > >> > > >> > >> https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6 >> > > >> > > I am using init-package-json module. So our createpackagejson script >> > feels >> > > very much like npm init. It generates defaults based on info from >> > > plugin.xml. Try it out! >> > > >> > > When publishing to CPR, plugman publish will temporarily move an >> existing >> > > package.json so it doesn't conflict with the package.json it needs to >> > > create to publish. >> > > >> > > >> > >> https://github.com/apache/cordova-lib/commit/adab8c9accfd769019837bb1cc36a2975f9742b0 >> > > >> > > I'd like to push this to master and do a tools release next week. >> After >> > the >> > > plugins release is completed, I will go through our plugins and add >> > > package.json files to them all. Next plugins release should be >> published >> > on >> > > npm as well as CPR. >> > > >> > > Thoughts? >> > > >> > >> >
