love this, having a cordova key is a v good idea while this bakes too On Wed, Feb 4, 2015 at 12:10 PM, Parashuram N (MS OPEN TECH) < panar...@microsoft.com> wrote:
> +1 to changing cordova-windows8 to cordova-windows. > > On 2/4/15, 12:05 PM, "Jesse" <purplecabb...@gmail.com> wrote: > > >Yes, you can skip all the 'windows8' stuff and just use 'windows'. > >windows8 is legacy and slowly all plugins are being migrated to just use > >the 'windows' section in plugin.xml > > > >@purplecabbage > >risingj.com > > > >On Wed, Feb 4, 2015 at 11:36 AM, Steven Gill <stevengil...@gmail.com> > >wrote: > > > >> I have made the changes you suggested. I like the idea of cordova parent > >> key. > >> > >> I added cordova-windows8 as a keyword but I would like someone from > >> microsoft to chime in about it. My understanding is that windows8 is > >>around > >> for legacy and windows is preferred. Please correct me if I'm wrong. I'd > >> prefer to just list windows and cordova-windows. > >> > >> If anyone else has feedback on the package.json file, please share! You > >>can > >> view it at > >> > >> > >> > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.j > >>son > >> > >> I am working on createpackagejson command now > >> https://issues.apache.org/jira/browse/CB-8416 > >> > >> On Tue, Feb 3, 2015 at 5:29 PM, Andrew Grieve <agri...@chromium.org> > >> wrote: > >> > >> > From looking at it, only thought is whether we should put all of the > >> > non-standard fields into a "cordova" parent key. E.g.: > >> > > >> > { > >> > "name": "cordova-plugin-device", > >> > "cordova": { > >> > "id": "org.apache.cordova.device", > >> > "platforms": [...] > >> > } > >> > } > >> > > >> > Sounds like we need to re-write the file when publishing to CPR > >>anyways, > >> so > >> > transforming from this to what is currently expected can be done in > >>that > >> > step. > >> > > >> > Other tidbits: > >> > - windows8 is missing from keywords. Intentional? (not sure if > >>windows is > >> > now an alias?) > >> > - author: might just set this to "Apache" > >> > > >> > > >> > On Tue, Feb 3, 2015 at 7:50 PM, Steven Gill <stevengil...@gmail.com> > >> > wrote: > >> > > >> > > Please review at > >> > > > >> > > > >> > > >> > >> > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.j > >>son > >> > > > >> > > You will notice that I added cordova-PLATFORM as a keyword. > >> > > > >> > > I have also kept the platforms tag for now. I can remove it but > >>maybe > >> we > >> > > can find some future use for it. We currently need it when > >>publising to > >> > CPR > >> > > but can add/rm it during plugman publish. > >> > > > >> > > I am going to create a createpackagejson command in plugman that > >>will > >> > build > >> > > something like this from plugin.xml. Other plugin devs will be able > >>to > >> > use > >> > > this command to quickly add package.json files to their plugins. > >> > > > >> > > I will then modify plugman publish to use the createpackagejson > >>command > >> > if > >> > > needed. Plugman publish will still have to add the contents of the > >> readme > >> > > (or doc/index.md) to the package.json as well as the platforms tag > >>if > >> we > >> > > decide to remove it. It will also have to change the package-name > >>field > >> > to > >> > > package-id when publishing to CPR. Once published, we can remove > >>these > >> > > changes package.json. > >> > > > >> > > If the package.json file looks good, I'm going to start adding one > >>to > >> all > >> > > of our plugins. > >> > > > >> > > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
