If it's applicable to more than build command, then it needs to be documented for the other commands that is applicable
Why a fix set of commands that this is applicable, what about "prepare" and "create" ? On Wed, Jul 30, 2014 at 11:42 AM, Carlos Santana <[email protected]> wrote: > > I agree Michal, not having cordova specific, my bad was not obvious the > "-- " the first time I read the email > > Mark I only see the -- [platformopts] only documented for "cordova run", > Does it also works for other commands i.e. compile, prepare? > > [1]: https://github.com/apache/cordova-cli/blob/master/doc/run.txt#L3 > > > On Wed, Jul 30, 2014 at 11:09 AM, Michal Mocny <[email protected]> > wrote: > >> Bryan: Awesome! Super glad everything is sensibly resolved. >> >> Carlos: Thats pretty common practice with unix tools: >> >> http://unix.stackexchange.com/questions/11376/what-does-double-dash-mean-also-known-as-bare-double-dash >> so I think its pretty sweet that we are not using some cordova-specific >> flag for this. >> >> -Michal >> >> >> On Wed, Jul 30, 2014 at 10:55 AM, Carlos Santana <[email protected]> >> wrote: >> >> > Oh Mark, after reading your email for the second time I got it :-) >> > So that's how it works today on the release version with a magic >> "--<space> >> > all the stuff to pass down" at the end of the cordova cli command? >> > >> > >> > On Wed, Jul 30, 2014 at 10:46 AM, Mark Koudritsky <[email protected]> >> > wrote: >> > >> > > --extraplatformargs would also be ok, but it's not really different >> from >> > > the -- separator as it works right now. >> > > You can do >> > > cordova run -- magicpostionarg --xcodeflag --bbflag=42 >> > > and it will pass along everything after the " -- " as is (in the >> original >> > > order). >> > > >> > > >> > > On Wed, Jul 30, 2014 at 10:36 AM, Carlos Santana < >> [email protected]> >> > > wrote: >> > > >> > > > Mark >> > > > What about having a generic door? meaning something like >> > > -extraplatformargs >> > > > cordova run --extraplatformargs="magicpostionarg --xcodeflag >> > --bbflag=42" >> > > > >> > > > then pass down the value of extraplatformargs, then platform scripts >> > > should >> > > > properly implement the parsing of arguments using "-" or "--" or for >> > now >> > > if >> > > > extraplatformargs contain position args they will get what they >> expect. >> > > > >> > > > >> > > > >> > > > On Wed, Jul 30, 2014 at 10:24 AM, Mark Koudritsky < >> [email protected]> >> > > > wrote: >> > > > >> > > > > On Wed, Jul 30, 2014 at 1:46 AM, Carlos Santana < >> > [email protected]> >> > > > > wrote: >> > > > > >> > > > > > Yep Michal I agree to update cli to pass down extra parameters >> to >> > > > > platform >> > > > > > scripts like it used. this allow for greater flexibility in >> > platform >> > > > > > scripts and no hardcoded platform concerns in cli. No need to >> > remove >> > > > nopt >> > > > > > if the this can be achieved. >> > > > > > >> > > > > > >> > > > > The list of flags to pass down to run will have to be hard coded >> in >> > the >> > > > > cli, unless we want to go back to the manual position based >> argument >> > > > > parsing. >> > > > > >> > > > > I don't think we want >> > > > > cordova run --verbose >> > > > > to mean something different than >> > > > > cordova --verbose run >> > > > > but I think it's ok to expect that >> > > > > cordova run -- --verbose will mean something different. >> > > > > And it also allows things like >> > > > > cordova --verbose run -- --verbose >> > > > > >> > > > > The -- separation is exactly what allows the flexibility to pass >> > > anything >> > > > > to the run and build scripts without telling the cli what to >> expect >> > or >> > > > not >> > > > > expect after the -- . >> > > > > >> > > > > But going back to the origins of this discussion. The lack of >> > > > documentation >> > > > > in help.txt about the -- thing is my bad. Thanks to Josh for >> adding >> > it >> > > > > yesterday. But why revert the behavior? (and why only for the >> pre-4.0 >> > > > > versions) If webworks is not affected, who is? Are those real >> people? >> > > If >> > > > > they have already hit, and possibly solved the problems caused by >> > this >> > > > > change, do they want to revert back? Would be glad to hear from >> them. >> > > > > >> > > > >> > > > >> > > > >> > > > -- >> > > > Carlos Santana >> > > > <[email protected]> >> > > > >> > > >> > >> > >> > >> > -- >> > Carlos Santana >> > <[email protected]> >> > >> > > > > -- > Carlos Santana > <[email protected]> > -- Carlos Santana <[email protected]>
