this element is used to specify the API Level,*not* the version number of the SDK
+1 max simply ensures that some new untested and potentially incompatible API level is not used. Where is the danger Joe? We just need to be sure that cordova-android@X.X.X somehow specifies what API levels it supports. Is this there? If it makes sense to exist in the Android SDK, then I think it also makes sense to expose as configurable. @purplecabbage risingj.com On Thu, Jul 10, 2014 at 11:58 AM, Joe Bowser <bows...@gmail.com> wrote: > -1 > > I like adding min, but max and target build can really break the build, > especially when we try and use newer Chromium features. PG Build has this > only because a method that we were using was removed from Cordova and they > have to support old versions. We want people to upgrade Cordova and this > makes it easier for people to stick to broken versions. > On Jul 10, 2014 11:40 AM, "Lisa Seacat DeLuca" <ldel...@us.ibm.com> wrote: > > > Sergey, this is awesome! Once we get your changes pulled in we should > > also update the documentation. I can see this being a popular little > > feature for users. > > > > > > Lisa > > @LisaSeacat > > > > > > > > [image: Inactive hide details for "Sergey Grebnov (Akvelon)" > ---07/10/2014 > > 04:23:07 AM---Implemented, pls take a look: https://github.c]"Sergey > > Grebnov (Akvelon)" ---07/10/2014 04:23:07 AM---Implemented, pls take a > > look: https://github.com/apache/cordova-lib/pull/56/files > > > > From: "Sergey Grebnov (Akvelon)" <v-seg...@microsoft.com> > > To: "dev@cordova.apache.org" <dev@cordova.apache.org> > > Date: 07/10/2014 04:23 AM > > Subject: RE: Android: add support of min/max/target SDK to config.xml > > ------------------------------ > > > > > > > > Implemented, pls take a look: > > https://github.com/apache/cordova-lib/pull/56/files > > https://issues.apache.org/jira/browse/CB-7114 > > > > Thx! > > Sergey > > -----Original Message----- > > From: tommy-carlos williams [mailto:to...@devgeeks.org > > <to...@devgeeks.org>] > > Sent: Monday, July 7, 2014 5:33 PM > > To: dev@cordova.apache.org > > Subject: Re: Android: add support of min/max/target SDK to config.xml > > > > +1 > > > > Another step towards build-artefact-land. > > > > > > > > On 7 July 2014 at 23:29:25, Andrew Grieve (agri...@chromium.org) wrote: > > > > I'd love to see this added. > > > > > > On Mon, Jul 7, 2014 at 7:29 AM, Sergey Grebnov (Akvelon) < > > v-seg...@microsoft.com> wrote: > > > > > Propose to add support of the following Android specific settings to > > > config.xml similar to PG Build[2]. Optional, could be used to override > > > default template values. I think this could be very useful and will > > > implement this if we agree. Thoughts? > > > > > > <preference name="android-minSdkVersion" value="10" /> <preference > > > name="android-targetSdkVersion" value="19" /> <preference > > > name="android-maxSdkVersion" value="20" /> > > > > > > [1] > > > http://developer.android.com/guide/topics/manifest/uses-sdk-element.ht > > > ml > > > [2] > > > http://docs.build.phonegap.com/en_US/configuring_preferences.md.html#_ > > > android_only > > > > > > Thx! > > > Sergey > > > > > > > > > >
