Created issues to sync cheq requirements for CLI https://issues.apache.org/jira/browse/CB-5298 https://issues.apache.org/jira/browse/CB-5297
On Tue, Nov 5, 2013 at 5:36 PM, Carlos Santana <[email protected]> wrote: > Sorry wrong link for iOS Check Reqs > > https://github.com/apache/cordova-cli/blob/master/src/metadata/ios_parser.js#L32 > > Should I open jira issues for these 2? > > > > On Tue, Nov 5, 2013 at 5:31 PM, Carlos Santana <[email protected]>wrote: > >> Similar problem with iOS cheq_reqs >> >> CLI Checks for XCode 4.5 as min [1] >> Platform Checks for XCode 4.6 as min [2] >> >> Which with XCode 5 out, I think Xcode 5.0.1 should be the minimum :-) >> >> [1]: >> https://github.com/apache/cordova-cli/blob/master/src/metadata/ios_parser.js#L32 >> [2]: >> https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46 >> >> >> >> On Tue, Nov 5, 2013 at 4:59 PM, Carlos Santana <[email protected]>wrote: >> >>> Based on CLI Design [1] >>> The CLI should not hold the code to check requirements (i.e. >>> src/metadata/android_parser.js) >>> >>> The CLI instead should delegate to platform by calling >>> (platform/android/cordova/check_reqs) >>> >>> >>> Today there is duplicate of code not in sync for Android and iOS (other >>> platforms delegate to cheq_reqs): >>> CLI src/metadata/[platform]/check_requirements [2] >>> Platform cordova/check_reqs [3] >>> >>> >>> >>> [1]: http://wiki.apache.org/cordova/CommandLineToolingDesign >>> [2]: >>> https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46 >>> [3]: >>> https://github.com/apache/cordova-android/blob/master/bin/lib/check_reqs.js >>> >>> >>> On Tue, Nov 5, 2013 at 4:34 PM, Braden Shepherdson >>> <[email protected]>wrote: >>> >>>> I don't know how this value got updated in the past, it should >>>> presumably >>>> be set to target the latest version of Android. >>>> >>>> +1 for bumping it to 19. >>>> >>>> Braden >>>> >>>> >>>> On Tue, Nov 5, 2013 at 4:19 PM, Gorkem Ercan <[email protected]> >>>> wrote: >>>> >>>> > Hello, >>>> > Does anyone recall the reason for CLI to having "android-17" as a hard >>>> > target dependency. >>>> > -- >>>> > Gorkem >>>> > >>>> >>> >>> >>> >>> -- >>> Carlos Santana >>> <[email protected]> >>> >> >> >> >> -- >> Carlos Santana >> <[email protected]> >> > > > > -- > Carlos Santana > <[email protected]> > -- Carlos Santana <[email protected]>
