We def do not want to do this before 3.0 ...too big of a change. I think while we are seeing lots of benefits in issue tracking for iOS I share Joe's anxiety that we may end up with cowboy upgrades conflicting with project upgrades. Lets get 3 out the door and have a look after.
Added to roadmap backlog which we'll be discussing much later this summer I'm sure. [1] [1] http://wiki.apache.org/cordova/RoadmapProjects On Tue, Jun 18, 2013 at 3:23 AM, Andrew Grieve <agri...@chromium.org> wrote: > I don't think it's caused any issues on iOS, and it definitely has improved > bug reports. That's because you get better stack traces on iOS though, I > don't think the same is true for Android. > > I'll also point out that with 3.0, the majority of the code will already be > in the form of source files since plugin code will not be in the form of > jars. > > There have been several times on Android where I've had back-and-forth on a > JIRA issue where I say "Hey - can you trying changing this line to that and > see what happens" and their reply is "I have a JAR and so can't do that". > If they have the source, then this flow works. > > Joe (or anyone else who thinks this is not a good idea) - I'd like to hear > more about why you think this will cause things to break? > > > On Mon, Jun 17, 2013 at 6:07 PM, Kerri Shotts <kerrisho...@gmail.com> wrote: > >> We surely have data on this, since iOS has transitioned; how many issues >> have been raised on iOS because someone mucked around where they shouldn't >> have? Perhaps not directly applicable to Android, but it would perhaps be a >> rough estimate. >> >> >> ___________________________________ >> Kerri Shotts >> photoKandy Studios, LLC >> >> On the Web: http://www.photokandy.com/ >> >> Social Media: >> Twitter: @photokandy, http://twitter.com/photokandy >> Tumblr: http://photokandy.tumblr.com/ >> Github: https://github.com/kerrishotts >> https://github.com/organizations/photokandyStudios >> CoderWall: https://coderwall.com/kerrishotts >> >> Apps on the Apple Store: >> >> https://itunes.apple.com/us/artist/photokandy-studios-llc/id498577828 >> >> Books: >> >> http://www.packtpub.com/phonegap-2-mobile-application-hotshot/book >> http://www.packtpub.com/phonegap-social-app-development/book >> >> >> >> On Jun 17, 2013, at 16:37, Joe Bowser <bows...@gmail.com> wrote: >> >> > My bet is six months >> > >> > On Mon, Jun 17, 2013 at 2:32 PM, Filip Maj <f...@adobe.com> wrote: >> >> I'm ambivalent on this issue. >> >> >> >> To play devil's advocate, Joe, it hasn't been an issue on iOS or Windows >> >> Phone, so any speculation that this _will_ be an issue in the future is >> >> just that: speculation. >> >> >> >> If anything we should set an over/under on how long it will take after >> >> introducing this change before we get "Hey gaiz I changed >> >> CordovaWebView.java and now nothing works!" issues ;) >> >> >> >> My bet is: a long time. >> >> >> >> On 6/17/13 2:11 PM, "Benn Mapes" <benn.ma...@gmail.com> wrote: >> >> >> >>> +1 >> >>> I really like having source code. On Windows Phone we have moved from a >> >>> pre-compiled .dll to just the source as well. Like Kerri said, it is >> very >> >>> helpful when stepping through your application and debugging any >> problems >> >>> you might have, as well as getting more people looking at the code and >> >>> understanding it better. >> >>> >> >>> If users don't want to look at the source at all they can just treat >> the >> >>> cordovaLib folder like it's a .jar and not touch it. >> >>> >> >>> >> >>> On Mon, Jun 17, 2013 at 1:04 PM, Joe Bowser <bows...@gmail.com> wrote: >> >>> >> >>>> -1 >> >>>> >> >>>> This only caters to a minority of our users. Most of our users can't >> >>>> debug >> >>>> Cordova, since they can't write Java (or even Javascript) well. >> >>>> >> >>>> I think this will have far more things break and we'll have a huge >> >>>> backlash >> >>>> from our mainstream users, just like when we deprecated plugins. >> >>>> On Jun 17, 2013 12:48 PM, "Andrew Grieve" <agri...@chromium.org> >> wrote: >> >>>> >> >>>>> I'd like to propose that instead of having the create script compile >> a >> >>>>> version of Cordova into a .jar, that instead it copies over the >> source >> >>>>> files instead. >> >>>>> >> >>>>> My main motivation is that doing so will make debugging native code >> >>>> much >> >>>>> easier since the source code will show up in Eclipse / Android Studio >> >>>> by >> >>>>> default instead of needing to reconfigure your project to get this to >> >>>> work. >> >>>>> >> >>>>> We did the same change on iOS a while ago (moving from a precompiled >> >>>>> framework library to just copying over source files), and I think the >> >>>>> results were quite positive. It helps users file better bug reports, >> >>>> and >> >>>> I >> >>>>> think also encourages them to submit bug fixes. It will also make it >> >>>> easier >> >>>>> for Plugin developers to figure out our APIs since they'll be able to >> >>>> see & >> >>>>> tweak the code. >> >>>>> >> >>>>> Agree / object? >> >> >>
