There is not much in DirectoryManager maybe it should be folded into FileUtils then we wouldn't need to make as many things public. Less to doc. On Jun 13, 2013 6:05 PM, "Steven Gill" <stevengil...@gmail.com> wrote:
> argh, I meant for Android > > > On Thu, Jun 13, 2013 at 3:04 PM, Steven Gill <stevengil...@gmail.com> > wrote: > > > Yeah. I have already done it on the 3.0.0 branch for ios. Camera plugin > > needed it. > > > > > > On Thu, Jun 13, 2013 at 3:02 PM, Tim Kim <timki...@gmail.com> wrote: > > > >> Hey gang, > >> > >> I also need to make some function in DirectoryManager public for the > file > >> api. We cool with that too? > >> The ones in question: > >> testFileExists > >> getFreeDiskSpace > >> testSaveLocationExists > >> > >> Looking like we should definitely make DirectoryManager as a public api > >> now. > >> > >> > >> > >> On 11 June 2013 12:51, Joe Bowser <bows...@gmail.com> wrote: > >> > >> > It's a part of plugin breakout. The main question is whether > >> > DirectoryManager should be a public API by documenting it, since a > >> > plugin needs it to function, not should we make it public. > >> > > >> > But yeah, make it public Steve! > >> > > >> > > >> > On Tue, Jun 11, 2013 at 12:48 PM, Simon MacDonald > >> > <simon.macdon...@gmail.com> wrote: > >> > > Huh, you shouldn't need to do that as the DirectoryManager and > >> > > CameraLauncher are in the same package. I guess you are moving > >> > > CameraLauncher into it's own package, in which case go for it. > >> > > > >> > > > >> > > Simon Mac Donald > >> > > http://hi.im/simonmacdonald > >> > > > >> > > > >> > > On Tue, Jun 11, 2013 at 3:43 PM, Steven Gill < > stevengil...@gmail.com> > >> > wrote: > >> > > > >> > >> For Android. I need to make > >> > >> DirectoryManager.getTempDirectoryPath public so it can work with > the > >> > camera > >> > >> plugin. > >> > >> > >> > >> -Steve > >> > >> > >> > > >> > >> > >> > >> -- > >> Timothy Kim > >> > > > > >
