agree to this, but also agree w/ joe that we should try and remove completely (if testing the browser handles correctly 2.3+)
On Thu, Jun 6, 2013 at 5:25 PM, Steven Gill <stevengil...@gmail.com> wrote: > We should leave network code in core. Maybe this is something we revisit > later on if we want to make network information its own plugin and are > willing to do the changes required to do so (No idea what that would > involve). > > If we aren't ripping it out of Android, we shouldn't rip it out for the > other platforms. > > > On Thu, Jun 6, 2013 at 3:16 PM, Brian LeRoux <b...@brian.io> wrote: > >> Seems simple enough. I find online/offline/pause/resume and other >> events of the app lifecycle to be plausibly core for all platforms. >> >> On Thu, Jun 6, 2013 at 4:44 PM, Joe Bowser <bows...@gmail.com> wrote: >> > Actually, online/offline has to be core, because it's part of the >> > bridge. We can't rip that out because some platform may need the >> > Online/Offline event bridge. That's a pretty serious gotcha. It's >> > also why it's a problem on Android and not on other platforms. >> > >> > Sorry, I don't have any easy answers for this one. >> > >> > On Thu, Jun 6, 2013 at 2:41 PM, Joe Bowser <bows...@gmail.com> wrote: >> >> How is this not a problem for the rest of the platforms? That's the >> >> first thing that I'm wondering right now. >> >> >> >> On Thu, Jun 6, 2013 at 2:37 PM, Tim Kim <timki...@gmail.com> wrote: >> >>> Hey gang, >> >>> >> >>> So I'm trying to rip out the android network plugin, but it appears the >> >>> android exec relies on the network plugin for online/offline events. >> >>> >> >>> >> https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=blob;f=lib/android/exec.js;h=206c09acb6d939b91e28b8813fa7fe318c2a4483;hb=0a5fa1fa255e12625969cef1aaeecd1582e5b389#l117 >> >>> >> >>> I'm not too sure how to cleanly rip out the network plugin stuff from >> >>> cordova js without potentially breaking the online/offline events, so I >> >>> figured I'd ask for some help. I'm thinking that we move network stuff >> to >> >>> be a core part of android or perhaps not have to rely on the network >> plugin >> >>> somehow. >> >>> >> >>> Related jira issue : >> >>> https://issues.apache.org/jira/browse/CB-3509#comment-13677532 >> >>> >> >>> -- >> >>> Timothy Kim >>
