Le sam. 18 févr. 2023 à 01:33, garydgregory (via GitHub)
<g...@apache.org> a écrit :
>
>
> garydgregory commented on PR #278:
> URL: 
> https://github.com/apache/commons-imaging/pull/278#issuecomment-1435423300
>
>    This might satisfy some static code analysis but it's -1 for me since this 
> PR now wastes memory allocating and building a List every single time. A bad 
> trade off IMO.
>
>    To make this even worth, the PR also looses a code comment. Was this code 
> change machine generated? That often happens with machine transforms.
>
>    What do others think?

Shouldn't it be a "switch"?

Regards,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@community.apache.org
For additional commands, e-mail: dev-h...@community.apache.org

Reply via email to