[ 
https://issues.apache.org/jira/browse/COMDEV-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17688213#comment-17688213
 ] 

Andrew Musselman commented on COMDEV-293:
-----------------------------------------

[~sebb] I agree.

In `scandist.py` there is an example commit from pubsub that looks like this:
    # e.g. {"committer": "sebb", "log": "Ensure we exit on control+C", 
"repository": "13f79535-47bb-0310-9956-ffa450edef68", "format": 1,
    # "changed": {"comdev/reporter.apache.org/trunk/scandist.py": {"flags": "U  
"}},
    # "date": "2015-07-13 13:38:33 +0000 (Mon, 13 Jul 2015)", "type": "svn", 
"id": 1690668}

For the test case in the original description, what form would it take in the 
pubsub-generated commit?

The regex in `scandist.py` catches the release string as shown below:

{{#!/usr/bin/env python3
import re
path = "release/spark/spark-2.2.2"
RELEASE_MATCH = r"^release/([^/]+)/"
match = re.match(RELEASE_MATCH, path)
print(match[0])

$ ./test-release.py
release/spark/}}

> scandist does not detect releases renamed from dist/dev
> -------------------------------------------------------
>
>                 Key: COMDEV-293
>                 URL: https://issues.apache.org/jira/browse/COMDEV-293
>             Project: Community Development
>          Issue Type: Bug
>          Components: Reporter Tool
>            Reporter: Sebb
>            Priority: Major
>
> The scandist script ignores commits which only affect a directory.
> This is OK for simple directory creation, but means that releases which are 
> created by renaming/copying from dist/dev are ignored.
> For example the following did not cause an email to be sent:
> $ svn log -r27902 -v https://dist.apache.org/repos/dist/
> ------------------------------------------------------------------------
> r27902 | tgraves | 2018-07-03 19:08:54 +0100 (Tue, 03 Jul 2018) | 2 lines
> Changed paths:
>    D /dev/spark/v2.2.2-rc2-bin
>    A /release/spark/spark-2.2.2 (from /dev/spark/v2.2.2-rc2-bin:27901)
> Publish spark 2.2.2
> ------------------------------------------------------------------------



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@community.apache.org
For additional commands, e-mail: dev-h...@community.apache.org

Reply via email to