It looks like those co-authored by are coming indeed from  the "suggestion"
workflow https://github.com/apache/airflow/pull/15100#discussion_r605489162
- github adds co-authored-by automatically when you add the suggestion.
If this is the case, then geems that if you want to do get the same from
manually pushed commits, those co-authored-by should be added automatically
(see git-mob hook).

J,


On Wed, Apr 7, 2021 at 12:25 PM antonio <anto...@vieiro.net> wrote:

> Mmm... maybe we have a misconfiguration in our github repository or
> something.
>
> When we try to do a squash-and-merge we don't have these
> "Co-authored-By" entries added automatically (see, for instance, [1]).
>
> I'll try to see what is going on, and post here if I find a solution.
>
> Thanks and kind regards,
> Antonio
>
>
> [1]
> https://pasteboard.co/JWd7Ij8u.png
>
> On 07/04/2021 10:00, Jarek Potiuk wrote:
> > This is automatically added in some scenarios of github workflow - for
> > example when you make a 'suggestion' and that suggestion is then
> > "committed", the "Co-authored-by" is added automatically.
> >
> > I think it also works (but I am not 100% sure) when you simply push your
> > commit on top of someone's branch (if you are a committer, by default you
> > can do it for people's forks unless they opt-out when forking).
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@community.apache.org
> For additional commands, e-mail: dev-h...@community.apache.org
>
>

-- 
+48 660 796 129

Reply via email to