bdelacretaz commented on pull request #17: URL: https://github.com/apache/comdev-site/pull/17#issuecomment-728040289
I built the site locally with these changes and the homepage has no difference with a build that does not have them. I'm not familiar with OpenGraph and have only limited experience with Hugo but as per https://gohugo.io/templates/internal/ I tried the following change: diff --git a/layouts/_default/baseof.html b/layouts/_default/baseof.html index f7f5f49..ff7ebfe 100644 --- a/layouts/_default/baseof.html +++ b/layouts/_default/baseof.html @@ -50,6 +50,7 @@ margin-top:1em; } </style> + {{ template "_internal/opengraph.html" . }} </head> <body> And with this I see a number of `<meta>` elements on the homepage: <meta property="og:title" content="Apache Community Development - Welcome" /> <meta property="og:description" content="The Community Development project creates and provides tools, processes, and advice to help open-source software projects improve their own community health." /> <meta property="og:type" content="website" /> <meta property="og:url" content="http://localhost:1313/"; /> <meta property="og:image" content="http://localhost:1313/images/aceu19_1.jpg"/> <meta property="og:site_name" content="Apache Community Development" /> So I suppose we should make this template change in addition to the changes in this PR, to include the OpenGraph metadata in the site pages? Or is there another way to access this new metadata that I'm missing? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@community.apache.org For additional commands, e-mail: dev-h...@community.apache.org
![http://localhost:1313/images/aceu19_1.jpg"/](http://localhost:1313/images/aceu19_1.jpg"/){kind=link}