Hi Gary,
On 8.11.2025 04:04, [email protected] wrote:
> Javadoc
>
> Use emphasis instead of italics
> ---
> .github/workflows/maven.yml | 13
> ++++---------
> .../commons/compress/harmony/pack200/Pack200Exception.java | 2 +-
> 2 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
> index dba5ae7c6..570a58b49 100644
> --- a/.github/workflows/maven.yml
> +++ b/.github/workflows/maven.yml
> @@ -36,15 +36,10 @@ jobs:
> java: [ 8, 11, 17, 21, 25 ]
> experimental: [false]
> # Keep the same parameter order as the matrix above
> - #
> - # PMD does not yet support Java 26 (see
> https://github.com/pmd/pmd/issues/5871).
> - # It is therefore too soon to run tests with Java 26.
> - # Uncomment the following lines once the above issue has been
> resolved.
> - #
> - # include:
> - # - os: ubuntu-latest
> - # java: 26-ea
> - # experimental: true
> + include:
> + - os: ubuntu-latest
> + java: 26-ea
> + experimental: true
This is exactly the kind of situation that undermines trust in the CTR
process:
- The change disabling JDK 26-ea runs was submitted by me as a PR and
approved by Sebb [1], representing a two-party review and agreement.
- In this commit titled “Javadoc”, the JDK 26-ea configuration was
reintroduced:
- If this was unintentional, it represents a significant oversight.
- If it was intentional, it effectively and silently reverts a
reviewed and agreed-upon change.
If there are reasons to re-enable JDK 26-ea directly on `master`, it
would be good to have a commit message explaining the motivation and why
it’s considered a “trivial” change (since it really isn’t).
Piotr
[1] https://github.com/apache/commons-compress/pull/724
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
