Hi Ryan, On 9.08.2025 01:43, Ryan McCarten wrote: > On Wed, Jul 16, 2025 Robert Turner wrote: > > I also find it very easy with the new naming to pick the wrong CS or CI. > Very easy to miss in code review as well, for such a potentially > important > difference. So, I have notable concerns about the choice in the > first place. > > > As an example, the 3.18.0 deprecation note for > StringUtils.endsWithIgnoreCase > suggests replacing it with the case _sensitive_ version of endsWith. > > https://github.com/apache/commons-lang/blob/rel/commons-lang-3.18.0/src/ > main/java/org/apache/commons/lang3/StringUtils.java#L1747-L1751 > <https://github.com/apache/commons-lang/blob/rel/commons-lang-3.18.0/ > src/main/java/org/apache/commons/lang3/StringUtils.java#L1747-L1751>
Would it help if we annotate the methods with the ErrorProne @InlineMe annotation? This would allow you to automatically convert all call site. Piotr [1] https://errorprone.info/docs/inlineme --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
