On Thu, 30 Jan 2025 at 00:00, Gary Gregory <garydgreg...@gmail.com> wrote: > > On Wed, Jan 29, 2025 at 11:51 AM sebb <seb...@gmail.com> wrote: > > > > On Wed, 29 Jan 2025 at 16:30, Gary Gregory <garydgreg...@gmail.com> wrote: > > > > > > [NOTE: This VOTE is only open for 24 hours as version 80 requires Java > > > 8 to run SpotBugs] > > > > I don't see why this is urgent. > > Version 80 is optional; if it breaks something, just revert to 79. > > I thought I had tested the update before performing the RC, but I did > it incorrectly. > It broke all Java 8 builds on the GH CI. It is urgent to me and is a > clear impediment to keep things moving forward instead of > flip-flopping the parent dependency around.
I think this shows that a new CP release should be tried in a few components first. > > > > > We have fixed a few bugs and added enhancements since Apache Commons > > > Parent 80 was released, so I would like to release Apache Commons > > > Parent 81. > > > > If it really is urgent, why does the above description not explain the > > reason? > > I did; I guess the very first line of the message was not clear enough: > > "[NOTE: This VOTE is only open for 24 hours as version 80 requires Java > 8 to run SpotBugs]" Yes, I saw that, but the comment applies to the vote only; what about the changes and release notes? The main description just says: "Version 81: This is a feature and maintenance release. Java 8 or later is required." This does not give a true impression of the release. I think it should be made more obvious that this fixes a broken CP 80. > HTH, > Gary > > > > > > Apache Commons Parent 81 RC1 is available for review here: > > > https://dist.apache.org/repos/dist/dev/commons/parent/81-RC1 (svn > > > revision 74522) > > > > > > The Git tag commons-parent-81-RC1 commit for this RC is > > > eeda875f9008c0feb820f58c08697ea2efd48334 which you can browse here: > > > > > > https://gitbox.apache.org/repos/asf?p=commons-parent.git;a=commit;h=eeda875f9008c0feb820f58c08697ea2efd48334 > > > You may checkout this tag using: > > > git clone https://gitbox.apache.org/repos/asf/commons-parent.git > > > --branch commons-parent-81-RC1 commons-parent-81-RC1 > > > > > > Maven artifacts are here: > > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1809/org/apache/commons/commons-parent/81/ > > > > > > These are the artifacts and their hashes: > > > > > > #Release SHA-512s > > > #Wed Jan 29 16:24:54 UTC 2025 > > > commons-parent-81-bom.json=851b5a9a5640b24bcbc37a62c251e5abc9f4b7f0370cd5388ee8269df0805160f08d40cc7d9efe021063abb7d9e610a20f85b22ed235d3daed6e12a2028027f1 > > > commons-parent-81-bom.xml=14d33995fdd014b47bdb963ca0dc0139c61104ac056ce1ca19686bd84f2f9cc0ffb411cb6f65b6a6b81754a4c6cc486a37a216cd2c30c6ecee6ad10056894407 > > > commons-parent-81-site.xml=14ba54f9594cfaf7a7d288c248a782e48258427d1ae0e7ce48e4b5be9e9f426d9fadb0bdfff518bd45a29fd9212348cafeac8d9188ae5c907871b62a42148768 > > > commons-parent-81-src.tar.gz=95286e4f56ecb18095bae9a7f786fe8ed2765b9dac930ceb470033bcb415fa118cea5fc77a228198fe62b874e0ef6487e34fd4034cc1c7d5f8181792d5cf9f19 > > > commons-parent-81-src.zip=6a4448acd2d678207f36a4bd4225d8379b945207fb30f5622451c316601cb81592ec994e5a56b2e260974859236ed4b432e5f5bc261e3480f4e2319faf11d5a0 > > > org.apache.commons_commons-parent-81.spdx.json=78349a2dfba79566706134e1a7bde27e690c8bdf43bf696ba24478146ede09b011255b7eda5565f647ae7334f673cb1c35b5b4012eaa7240ed9101b22cf8b971 > > > > > > > > > > > > I have tested this with 'mvn' and 'mvn clean install site' using: > > > *** > > > Use the output from "mvn -version" for each combination you tested. > > > Windows: ver > > > Linux: uname -a > > > *** > > > > > > Details of changes since 80 are in the release notes: > > > > > > https://dist.apache.org/repos/dist/dev/commons/parent/81-RC1/RELEASE-NOTES.txt > > > > > > https://dist.apache.org/repos/dist/dev/commons/parent/81-RC1/site/changes.html > > > > > > Site: > > > > > > https://dist.apache.org/repos/dist/dev/commons/parent/81-RC1/site/index.html > > > (note some *relative* links are broken and the 81 directories are > > > not yet created - these will be OK once the site is deployed.) > > > > > > RAT Report: > > > > > > https://dist.apache.org/repos/dist/dev/commons/parent/81-RC1/site/rat-report.html > > > > > > KEYS: > > > https://downloads.apache.org/commons/KEYS > > > > > > Please review the release candidate and vote. > > > This vote will close no sooner than 24 hours from now. > > > > > > [ ] +1 Release these artifacts > > > [ ] +0 OK, but... > > > [ ] -0 OK, but really should fix... > > > [ ] -1 I oppose this release because... > > > > > > Thank you, > > > > > > Gary Gregory, > > > Release Manager (using key 86fdc7e2a11262cb) > > > > > > The following is intended as a helper and refresher for reviewers. > > > > > > Validating a release candidate > > > ============================== > > > > > > These guidelines are NOT complete. > > > > > > Requirements: Git, Java, and Maven. > > > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > > > 1a) Download and decompress the source archive from: > > > > > > https://dist.apache.org/repos/dist/dev/commons/parent/81-RC1/source > > > > > > 1b) Check out the RC tag from git (optional) > > > > > > This is optional, as a reviewer must check source distributions as a > > > minimum. > > > > > > git clone https://gitbox.apache.org/repos/asf/commons-parent.git > > > --branch commons-parent-81-RC1 commons-parent-81-RC1 > > > cd commons-parent-81-RC1 > > > > > > 2) Checking the build > > > > > > All components should include a default Maven goal, such that you can > > > run 'mvn' from the command line by itself. > > > > > > 2) Check Apache licenses > > > > > > This step is not required if the site includes a RAT report page which > > > you then must check. > > > This check should be included in the default Maven build, but you can > > > check it with: > > > > > > mvn apache-rat:check > > > > > > 3) Check binary compatibility > > > > > > This step is not required if the site includes a JApiCmp report page > > > which you then must check. > > > This check should be included in the default Maven build, but you can > > > check it with: > > > > > > mvn verify -DskipTests -P japicmp japicmp:cmp > > > > > > 4) Build the package > > > > > > This check should be included in the default Maven build, but you can > > > check it with: > > > > > > mvn -V clean package > > > > > > You can record the Maven and Java version produced by -V in your VOTE > > > reply. > > > To gather OS information from a command line: > > > Windows: ver > > > Linux: uname -a > > > > > > 4b) Check reproducibility > > > > > > To check that a build is reproducible, run: > > > > > > mvn clean verify artifact:compare -DskipTests > > > -Dreference.repo=https://repository.apache.org/content/repositories/staging/ > > > '-Dbuildinfo.ignore=*/*.spdx.json' > > > > > > Note that this excludes SPDX files from the check. > > > > > > 5) Build the site for a single module project > > > > > > Note: Some plugins require the components to be installed instead of > > > packaged. > > > > > > mvn site > > > Check the site reports in: > > > - Windows: target\site\index.html > > > - Linux: target/site/index.html > > > > > > -the end- > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
