This lazy vote passes with the following votes: +1 Gary Gregory (ggregory, binding) +1 Herve Boutemy (hboutemy, non-binding)
A to-do is to improve the instructions and/or the release process for reproducible builds. TY, Gary On Wed, Jan 8, 2025 at 6:30 PM Herve Boutemy <hbout...@apache.org> wrote: > > +1 > no issue detected while checking Reproducible Builds for this one: I suppose > it's just because there is no CycloneDX output, then the local repository > issue remains undetected :) > > for people rebuilding and voting, checking the output of your local rebuild > against staged content can be very simple: > > mvn -Papache-release -Dgpg.skip clean verify \ > artifact:compare > -Dreference.repo=https://repository.apache.org/content/repositories/staging/ > > you can customize arguments to match precise commons build parameters: just > avoid install, but use verify > the artifact:compare with -Dreference.repo is the magic that will download > from staging and compare your local output against staged content > > IMHO this is typical instructions that would be useful to add to your > classical release check process > > Regards, > > Hervé > > On 2025/01/08 13:01:44 Gary Gregory wrote: > > We have fixed a few bugs and added enhancements since Apache Commons > > Build Plugin Maven Mojo 1.14.1 was released, so I would like to > > release Apache Commons Build Plugin Maven Mojo 1.15.0. > > > > The main change is an update to commons-parent which picks up the > > upgrade from Doxia 1 to 2. > > > > Apache Commons Build Plugin Maven Mojo 1.15.0 RC1 is available for review > > here: > > https://dist.apache.org/repos/dist/dev/commons/build-plugin/1.15.0-RC1 > > (svn revision 74041) > > > > The Git tag commons-build-plugin-1.15.0-RC1 commit for this RC is > > e77a511bc80577ba272aac169be6a166b5fa3294 which you can browse here: > > > > https://gitbox.apache.org/repos/asf?p=commons-build-plugin.git;a=commit;h=e77a511bc80577ba272aac169be6a166b5fa3294 > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-build-plugin.git > > --branch commons-build-plugin-1.15.0-RC1 > > commons-build-plugin-1.15.0-RC1 > > > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/orgapachecommons-1800/org/apache/commons/commons-build-plugin/1.15.0/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Wed Jan 08 12:56:30 UTC 2025 > > commons-build-plugin-1.15.0-bin.tar.gz=d00b5c024b46feb24d860cea6d84ce090477ec60661b22c439560b2ee7d189d57bd45e33094984881c57369d94a749a6b2397dd7a0578e249668c1f41764dce0 > > commons-build-plugin-1.15.0-bin.zip=777be8e558ef9f55e19235a3d77127ac96f95c48c088e93d052b09dc81878a665dbc1087fa82add0a1df13e1546cdbc32305a35dd69f477d41541a6dda42e011 > > commons-build-plugin-1.15.0-sources.jar=dd413e578c9608c41d2d4f576f7fd7f8974be871974bb7a1e8867c547ad3569713c3a8cdcef1a601eaa56abb5447821c3b31506f8831c4c4b8b3b6426f563cde > > commons-build-plugin-1.15.0-src.tar.gz=4ce5180787b49dbb4646bf10456acdbe8114fde3e6e8d455bcb1ae0aefba122083973dc390f2bdc9d07c78336b04b6a4430a6989723848101d89e8022b616739 > > commons-build-plugin-1.15.0-src.zip=fbf20fb67c47a95bfbc22d4128e32bcf0cff8c29c8a594bdd32023e4a15ccda1615e4241a99b2f3c871c5102e0be6576cc351019faf882f1f9886d6b33b7653d > > commons-build-plugin-1.15.0-test-sources.jar=386a4f6ec7fb1475f0afb1bc99c8159ba5365309382abb0b7a29e8d05fb5dc8736318835c95cfd61653cae196109172533db57146d2a51243caecc6dc490588c > > commons-build-plugin-1.15.0-tests.jar=f62dc1dcb832b8d7834a60eeeeeaeffdede31156f566b4b3d2a713075ee2feeb03b2443af5bc4ba049139ea6e0697b96439382c9024e2e68d4f61aefff138301 > > > > I have tested this with 'mvn' and 'mvn -e -V -P release -P test-deploy > > -P jacoco -P japicmp clean package site deploy' using: > > > > openjdk version "17.0.13" 2024-10-15 > > OpenJDK Runtime Environment Homebrew (build 17.0.13+0) > > OpenJDK 64-Bit Server VM Homebrew (build 17.0.13+0, mixed mode, sharing) > > > > Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937) > > Maven home: /opt/homebrew/Cellar/maven/3.9.9/libexec > > Java version: 17.0.13, vendor: Homebrew, runtime: > > /opt/homebrew/Cellar/openjdk@17/17.0.13/libexec/openjdk.jdk/Contents/Home > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "mac os x", version: "15.2", arch: "aarch64", family: "mac" > > > > Darwin ****.local 24.2.0 Darwin Kernel Version 24.2.0: Fri Dec 6 > > 19:03:40 PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T6041 arm64 > > Docker version 27.3.1, build ce12230 > > > > > > Details of changes since 1.14.1 are in the release notes: > > > > https://dist.apache.org/repos/dist/dev/commons/build-plugin/1.15.0-RC1/RELEASE-NOTES.txt > > > > https://dist.apache.org/repos/dist/dev/commons/build-plugin/1.15.0-RC1/site/changes.html > > > > Site: > > > > https://dist.apache.org/repos/dist/dev/commons/build-plugin/1.15.0-RC1/site/index.html > > (note some *relative* links are broken and the 1.15.0 directories > > are not yet created - these will be OK once the site is deployed.) > > > > JApiCmp Report (compared to 1.14.1): > > > > https://dist.apache.org/repos/dist/dev/commons/build-plugin/1.15.0-RC1/site/japicmp.html > > > > *** > > Note that the above report notes several errors. > > These are considered OK for the reasons stated below. > > These exceptions are also noted in the Changes and Release Notes. > > > > Errors reported: > > - methods added to interface: OK because that does not affect > > binary compatibility. > > - etc. > > *** > > > > RAT Report: > > > > https://dist.apache.org/repos/dist/dev/commons/build-plugin/1.15.0-RC1/site/rat-report.html > > > > KEYS: > > https://downloads.apache.org/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > The following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1a) Clone and checkout the RC tag > > > > git clone https://gitbox.apache.org/repos/asf/commons-build-plugin.git > > --branch commons-build-plugin-1.15.0-RC1 > > commons-build-plugin-1.15.0-RC1 > > cd commons-build-plugin-1.15.0-RC1 > > > > 1b) Download and unpack the source archive from: > > > > https://dist.apache.org/repos/dist/dev/commons/build-plugin/1.15.0-RC1/source > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > > you then must check. > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > Older components still use Apache Clirr: > > > > This step is not required if the site includes a Clirr report page > > which you then must check. > > > > mvn clirr:check > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > This step is not required if the site includes a JApiCmp report page > > which you then must check. > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > -the end- > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
