For me, createCalendar() returns: java.util.GregorianCalendar[time=1135991700000,areFieldsSet=true,areAllFieldsSet=false,lenient=true,zone=sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null],firstDayOfWeek=2,minimalDaysInFirstWeek=4,ERA=1,YEAR=2005,MONTH=11,WEEK_OF_YEAR=52,WEEK_OF_MONTH=5,DAY_OF_MONTH=31,DAY_OF_YEAR=365,DAY_OF_WEEK=7,DAY_OF_WEEK_IN_MONTH=5,AM_PM=0,HOUR=1,HOUR_OF_DAY=1,MINUTE=15,SECOND=0,MILLISECOND=0,ZONE_OFFSET=0,DST_OFFSET=0]
You? Gary On Wed, Dec 25, 2024 at 5:58 PM Dávid Szigecsán <sige...@gmail.com> wrote: > I don't know either. The created calendar `final Calendar cal20051231 = > createCalendar(GMT, 20051231, 11500);` means it is 2005-12-31 01:15:00. I > can't understand yet how could it be a day before (2005-12-30) in your > case. > > Could it be the createCalendar() method, which generates the > Calendar wrongly for some reason on your system or the issue is in this > specific test case only? > > Gary Gregory <garydgreg...@gmail.com> ezt írta (időpont: 2024. dec. 25., > Sze, 22:58): > > > Hi Dávid, > > > > Thank you for having a look. > > > > I can't figure out why this is failing on my setup. Quite annoying since > I > > can't build or consider creating a release candidate until this is > > addressed. > > > > Gary > > > > On Wed, Dec 25, 2024, 4:31 PM Dávid Szigecsán <sige...@gmail.com> wrote: > > > > > Hi, > > > > > > I checked it on Java 23 and seemed fine. > > > > > > [INFO] Running > > org.apache.commons.validator.routines.CalendarValidatorTest > > > [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > > > 0.104 s -- in > org.apache.commons.validator.routines.CalendarValidatorTest > > > > > > Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937) > > > Maven home: C:\Users\sigee\AppData\Local\JetBrains\IntelliJ IDEA > > > 2024.3.1.1\plugins\maven\lib\maven3 > > > Java version: 23.0.1, vendor: Oracle Corporation, runtime: > > > C:\Users\sigee\.jdks\openjdk-23.0.1 > > > Default locale: hu_HU, platform encoding: UTF-8 > > > OS name: "windows 10", version: "10.0", arch: "amd64", family: > "windows" > > > > > > The test seems not changed functionally, just a bit of refactoring, so > it > > > should not be failing in my opinion. > > > - There are a couple of variable extraction > > > - Variable renaming from cal20050101 to cal20051231, which is valid, > > > because it contains that value. > > > > > > On the other hand, I would do some more refactoring. > > > Eg. > > > - There is a new variable called patternA, but it could be earlier in > the > > > method and used in the US, DE section also, because it uses the same > > > pattern inside the assert. > > > - Same for patternB variable > > > > > > Regards, > > > David > > > > > > Gary Gregory <garydgreg...@gmail.com> ezt írta (időpont: 2024. dec. > 25., > > > Sze, 19:53): > > > > > > > Hi All, > > > > > > > > With the HEAD of git master (commit > > > > 2c1898f65ed46aa5c0f340f63b5e1f4a8b86e4f0), I get: > > > > > > > > [WARNING] Tests run: 25, Failures: 0, Errors: 0, Skipped: 1, Time > > > elapsed: > > > > 0.007 s -- in > org.apache.commons.validator.routines.EmailValidatorTest > > > > [INFO] Running > > > org.apache.commons.validator.routines.CalendarValidatorTest > > > > [ERROR] Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time > > elapsed: > > > > 0.009 s <<< FAILURE! -- in > > > > org.apache.commons.validator.routines.CalendarValidatorTest > > > > [ERROR] > > > > > org.apache.commons.validator.routines.CalendarValidatorTest.testFormat > > -- > > > > Time elapsed: 0.003 s <<< FAILURE! > > > > org.opentest4j.AssertionFailedError: default ==> expected: > <30/12/2005> > > > but > > > > was: <31/12/2005> > > > > at > > > > > > > > > > > > > > org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) > > > > at > > > > > > > > > > > > > > org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) > > > > at > > org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197) > > > > at > > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182) > > > > at > org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1156) > > > > at > > > > > > > > > > > > > > org.apache.commons.validator.routines.CalendarValidatorTest.testFormat(CalendarValidatorTest.java:287) > > > > at java.base/java.lang.reflect.Method.invoke(Method.java:569) > > > > at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) > > > > at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) > > > > > > > > But GitHub is OK. > > > > > > > > Does anyone else see this? > > > > > > > > This happens on Java 8, 11, 17, 21, and 23. For example: > > > > > > > > openjdk version "17.0.13" 2024-10-15 > > > > OpenJDK Runtime Environment Homebrew (build 17.0.13+0) > > > > OpenJDK 64-Bit Server VM Homebrew (build 17.0.13+0, mixed mode, > > sharing) > > > > > > > > Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937) > > > > Maven home: /opt/homebrew/Cellar/maven/3.9.9/libexec > > > > Java version: 17.0.13, vendor: Homebrew, runtime: > > > > /opt/homebrew/Cellar/openjdk@17 > > > /17.0.13/libexec/openjdk.jdk/Contents/Home > > > > Default locale: en_US, platform encoding: UTF-8 > > > > OS name: "mac os x", version: "15.2", arch: "aarch64", family: "mac" > > > > > > > > Darwin ***.local 24.2.0 Darwin Kernel Version 24.2.0: Fri Dec 6 > > 19:03:40 > > > > PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T6041 arm64 > > > > Docker version 27.3.1, build ce12230 > > > > > > > > So it could be my Locale / TimeZone. > > > > > > > > Default locale: en_US > > > > TZ: GMT-5 (US EST) > > > > > > > > Any thoughts? > > > > TY, > > > > Gary > > > > > > > > > >
