Hello serwserw...@gmail.com, Thank you for your email.
Here are a few questions: What passes the criteria of "simple cases"? Should this be enforced or can it be enforced? With Checkstyle? Somethings else? Considering: - that we support Java 8 and up to the current version. - that we don't say which Java vendor we support. - that the JLS (which version...) only suggests that a vendor could implement string concatenation using one of the Java stock classes. Is there a risk that changing to not using our unsynchronized class have performance side-effects? Ty! Gary On Sat, Dec 14, 2024, 10:08 AM Serw <serwserw...@gmail.com> wrote: > Dear Apache Commons Community, > > In my recent PR #1332, I replaced a StringBuilder usage with string > concatenation in a toString method for improved readability. During the > review, it was suggested this change should align with a broader project > standard. > > Would the community support using string concatenation over StringBuilder > for simple cases? Modern JDKs (8+) optimize string concatenation > efficiently, making it both concise and performant. > > If agreed, I can implement consistent changes across the codebase. > > Looking forward to your feedback! > > PR - https://github.com/apache/commons-lang/pull/1332 >
