On Tue, Oct 29, 2024 at 3:30 AM Emmanuel Bourg <ebo...@apache.org> wrote:
> Hi Gary, > > Le 28/10/2024 à 23:02, Gary Gregory a écrit : > > > Would you please explain why you need this change? > > > > TY, > > Gary > > static methods are not inherited and can't be overridden in a subclass. > The 'final' modifier on a static method has no effect and can be removed. > That's not how Java works [1]. A static final method cannot be overridden, you cannot redefine it in a subclass as another static method with the same signature, the compiler will not allow it. In addition, this change prevents the JVM from inlining the code in some cases, see [1]. You should revert this change: Allowing subclasses to (unwisely) redefine all these static methods is confusing and loses the performance optimization the JVM can do. The argument that the class itself could be made final would be for the next major version. Gary [1] https://docs.oracle.com/javase/specs/jls/se21/html/jls-8.html#jls-8.4.3.2 > > Emmanuel Bourg > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
