Hello all, Whichever names we pick if we accept the contribution, I think it is best to look at the method names in context, not standalone.
For example, you would "say": stopWatch.accept(x -> ...) and so on. I find it simpler to match the new names with the delegate but YMMV ;-) All the names should be consistent in some way. IOW, ALL method names could be - stopWatch.add(...), or - stopWatch.time(...), or - ... Wdyt? Gary On Sat, Aug 17, 2024, 2:55 PM Peter Burka <pe...@quux.net> wrote: > I think this is a useful addition, but I wonder if these new APIs are > misnamed: StopWatch::test doesn't actually test, nor does StopWatch::accept > consume. Instead, these all wrap lambdas in a timed version of the same > type. (There's probably some lambda calculus terminology for this.) > > I'd propose renaming all of the functional interface-wrapping functions to > use a single, overloaded name, e.g. StopWatch::timed(...) or > StopWatch::withTiming(...) > > /peter > > On Fri, Aug 16, 2024, 10:50 PM Gary Gregory <garydgreg...@gmail.com> > wrote: > > > Hi all, > > > > Please provide any feedback on > > - LANG-1747: Measure the execution time of functional interfaces #1254 > > - https://github.com/apache/commons-lang/pull/1254/ > > TY! > > Gary > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > >
