You don't have to accept the PRs, but they should be addressed. If the logback PR requires Java 11, then close it (and maybe check to see if there's something in between 1.3.12 and 1.5.3 that logging should upgrade to instead).
If logkit isn't going to be supported, cool, but then close the PR and delete the dependency and all code that needs it. Address the other four open PRs as each requires. It is important to address PRs and triage issues regularly, and certainly before any non-patch, non-emergency release. IMHO lack of issue triage and PR review is a very good indicator that a project is not safe to release. On Sun, Mar 17, 2024 at 12:45 PM Gary Gregory <garydgreg...@gmail.com> wrote: > > For example? The Logback PR requires Java 11. What else? Logkit? Maybe but > I've never heard anyone ask for that. > > Projects have open PRs all the time for dependencies or other reasons, > that's no reason to downvote a release candidate IMO. I prefer RERO to > bigger releases FWIW. > > Gary > > On Sun, Mar 17, 2024, 8:05 AM Elliotte Rusty Harold <elh...@ibiblio.org> > wrote: > > > -1 > > > > There are multiple open PRs waiting for review, including apparently > > two to upgrade the dependent logging libraries this library is a > > facade over, wh9ich seem pretty important. These should be resolved > > before cutting the next release. > > > > On Sun, Mar 17, 2024 at 11:49 AM Gary Gregory <garydgreg...@gmail.com> > > wrote: > > > > > > We have fixed a few bugs and added some enhancements since Apache > > > Commons Logging 1.3.0 was released, so I would like to release Apache > > > Commons Logging 1.4.0. > > > > > > Apache Commons Logging 1.4.0 RC1 is available for review here: > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.4.0-RC1 > > > (svn revision 67977) > > > > > > The Git tag commons-logging-1.4.0-RC1 commit for this RC is > > > ac55303ba66dc0046f6118f74eecd46c74eeeb4a which you can browse here: > > > > > https://gitbox.apache.org/repos/asf?p=commons-logging.git;a=commit;h=ac55303ba66dc0046f6118f74eecd46c74eeeb4a > > > You may checkout this tag using: > > > git clone https://gitbox.apache.org/repos/asf/commons-logging.git > > > --branch commons-logging-1.4.0-RC1 commons-logging-1.4.0-RC1 > > > > > > Maven artifacts are here: > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1703/commons-logging/commons-logging/1.4.0/ > > > > > > These are the artifacts and their hashes: > > > > > > #Release SHA-512s > > > #Sun Mar 17 11:41:39 UTC 2024 > > > > > commons-logging-1.4.0-sources.jar=5e71710bec4a5a86efffd32da7460a8cad072732287a243c936d6cdc27115823526278cea8f469ff2108a0d0b07cd54e97edd35c252b7ea706cede65051ad8bf > > > > > commons-logging-1.4.0-src.zip=937f21c05d3bbbb86733e1ba41cd3f655518799b4155d22884e0a180730df12c9192cfd29e47991a5178ac56db74645a25074ea609cfa34ae5796ae52ba9361b > > > > > commons-logging-1.4.0-tests.jar=9546b9d8b0af2ae349eb05f0613036798d6172f055bebd337846a0baa18fd26a4136381cdf22583b473d2e3d838da9ca4351b01f75350b78f1b265d96fe403d7 > > > > > commons-logging-1.4.0-bom.json=f0a6d8241df605eb658679aa2668d3fa884b6cd5632bc11fe0467a22e9d321dc4a273fb996281ef8228ae9db89a18e268c9825d9f02deb707842fd51157b3b24 > > > > > commons-logging-1.4.0-javadoc.jar=2defa71a19149811f7ecf1e5bf66508ac684641afb78ae8fd54dd4ac68a5f186d9ea44364b6171ee683cb9fe01f97908ca1a7c2d14b9cdd451330d9dc3f00ac4 > > > > > commons-logging-1.4.0-api.jar=4874cbcda59f70e66ff1596e27a56df4f0ff8b37dfc97c5cf4cdccbe1f54ebbed68d3c920f45ab2d9baf3a22117c3adb2cc3a1c8df539f61a4c31b26f0ca49ed > > > > > commons-logging-1.4.0-src.tar.gz=bfe6a392ce9990c686c1e14a4c23f5a4251e2614a3a07d7afb5b5052e182ae14596b19b4176afa15d6d750ba603a6fc9ec1015d3ce08c98ab3b545daf471125e > > > > > commons-logging-1.4.0-bin.tar.gz=22df1b2963df0c35ce3fea7f35602a4af8ace5c74079f696480e601700ef8b15703d5011de5fbc10aea74f8b1f73f96a07d519839f40e38c6bc2daf918b6c520 > > > > > commons-logging_commons-logging-1.4.0.spdx.json=e4a5ddda46381f31a3ef506fab4e02c4ec952094ea70dc6209c6ed27bb7a941d13491762f1546d53ce09a3eb64ffb5cd406c12dd44d5efb1bbe4c7ee3e8cbde6 > > > > > commons-logging-1.4.0-test-sources.jar=06239eb9bb64e28f6b835a4b55479d9637f597e9c114070f2bf5243f2a82f656b03dca54f64cd89589d2d1cf789b56c99cc45f0cb578d7b6ef100b2a8cbbd512 > > > > > commons-logging-1.4.0-bom.xml=e15f5ff2bc7b7416fe83ee91f1cd7b7e18cab58135e644716ca2e7bbe871668283c5c16faef8faa04f1632d3bf994772ac3a68c8dbd20ae2835429c482e2ca22 > > > > > commons-logging-1.4.0-bin.zip=80639fe769a95f8b810983de1e21fd3cfb0efd9931c07cd21e206c1a80c06fd98223cbb0afe6189b6daa256fc49fff8d6463bfbab73af1675cf3863a0fe35bb6 > > > > > commons-logging-1.4.0-adapters.jar=ff6e19aaeaf82443dd3885acf7b4e83da1ebed55d3d34093060a180759177cb6ab164ed2bf07c31af52758efbeb5137a0a75c1a29bc17a5bd578a7b899514b23 > > > > > > > > > I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P > > > jacoco -P japicmp clean package site deploy' using: > > > > > > openjdk version "17.0.10" 2024-01-16 > > > OpenJDK Runtime Environment Homebrew (build 17.0.10+0) > > > OpenJDK 64-Bit Server VM Homebrew (build 17.0.10+0, mixed mode, sharing) > > > > > > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) > > > Maven home: /usr/local/Cellar/maven/3.9.6/libexec > > > Java version: 17.0.10, vendor: Homebrew, runtime: > > > /usr/local/Cellar/openjdk@17/17.0.10/libexec/openjdk.jdk/Contents/Home > > > Default locale: en_US, platform encoding: UTF-8 > > > OS name: "mac os x", version: "14.3.1", arch: "x86_64", family: "mac" > > > > > > Darwin **** 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:28:58 > > > PST 2023; root:xnu-10002.81.5~7/RELEASE_X86_64 x86_64 > > > > > > Details of changes since 1.3.0 are in the release notes: > > > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.4.0-RC1/RELEASE-NOTES.txt > > > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.4.0-RC1/site/changes-report.html > > > > > > Site: > > > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.4.0-RC1/site/index.html > > > (note some *relative* links are broken and the 1.4.0 directories > > > are not yet created - these will be OK once the site is deployed.) > > > > > > JApiCmp Report (compared to 1.3.0): > > > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.4.0-RC1/site/japicmp.html > > > > > > RAT Report: > > > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.4.0-RC1/site/rat-report.html > > > > > > KEYS: > > > https://downloads.apache.org/commons/KEYS > > > > > > Please review the release candidate and vote. > > > This vote will close no sooner than 72 hours from now. > > > > > > [ ] +1 Release these artifacts > > > [ ] +0 OK, but... > > > [ ] -0 OK, but really should fix... > > > [ ] -1 I oppose this release because... > > > > > > Thank you, > > > > > > Gary Gregory, > > > Release Manager (using key 86fdc7e2a11262cb) > > > > > > For following is intended as a helper and refresher for reviewers. > > > > > > Validating a release candidate > > > ============================== > > > > > > These guidelines are NOT complete. > > > > > > Requirements: Git, Java, Maven. > > > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > > > 1a) Clone and checkout the RC tag > > > > > > git clone https://gitbox.apache.org/repos/asf/commons-logging.git > > > --branch commons-logging-1.4.0-RC1 commons-logging-1.4.0-RC1 > > > cd commons-logging-1.4.0-RC1 > > > > > > 1b) Download and unpack the source archive from: > > > > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.4.0-RC1/source > > > > > > 2) Check Apache licenses > > > > > > This step is not required if the site includes a RAT report page which > > > you then must check. > > > > > > mvn apache-rat:check > > > > > > 3) Check binary compatibility > > > > > > Older components still use Apache Clirr: > > > > > > This step is not required if the site includes a Clirr report page > > > which you then must check. > > > > > > mvn clirr:check > > > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > > > This step is not required if the site includes a JApiCmp report page > > > which you then must check. > > > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > > > 4) Build the package > > > > > > mvn -V clean package > > > > > > You can record the Maven and Java version produced by -V in your VOTE > > reply. > > > To gather OS information from a command line: > > > Windows: ver > > > Linux: uname -a > > > > > > 5) Build the site for a single module project > > > > > > Note: Some plugins require the components to be installed instead of > > packaged. > > > > > > mvn site > > > Check the site reports in: > > > - Windows: target\site\index.html > > > - Linux: target/site/index.html > > > > > > -the end- > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > -- > > Elliotte Rusty Harold > > elh...@ibiblio.org > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > -- Elliotte Rusty Harold elh...@ibiblio.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
