Hi Gary,
The build passed after ~13 mins on my old thinkpad
Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /opt/apache-maven-3.8.5
Java version: 17.0.10, vendor: Private Build, runtime:
/usr/lib/jvm/java-17-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-100-generic", arch: "amd64", family:
"unix"
But this called my attention
These are the artifacts and their hashes:
>
> ${commons.sha512list}
I think that's fine and it's just probably something missing somewhere to
configure the commons-release-plugin or parent to output the sha here.
But then I decided to take a better look at the archives just to be sure.
Are the bin files for VFS always nearly empty, with just three files?
https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/binaries/
Can't really recall, maybe it's because the module is a bit special or
multi-module... really can't recall seeing an archive with just three text
files...
The site reports also look messed up, e.g. empty japicmp, and exception
printed in
https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/pmd.html...
but I do recall needing some command to build multi-module components... so
maybe that's expected and reviewers need to build it locally?
Running out of time and also wanting to have a quick look at some Imaging
issues, so won't have time to dig deeper here, can you take a look at these
points and I will come back to continue the review if the above is fine,
please? It's also late here, so it could be just me sleepy doing something
wrong/silly.
Cheers!
On Sun, 10 Mar 2024 at 23:02, Gary Gregory <garydgreg...@gmail.com> wrote:
> We have fixed a few bugs and added some enhancements since Apache
> Commons VFS Project 2.9.0 was released, so I would like to release
> Apache Commons VFS Project 2.10.0.
>
> Apache Commons VFS Project 2.10.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1 (svn
> revision 67866)
>
> The Git tag commons-vfs-2.10.0-RC1 commit for this RC is
> 6aec37ad5fdcd4d0f2ca0330f310eb48a1585462 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-vfs.git;a=commit;h=6aec37ad5fdcd4d0f2ca0330f310eb48a1585462
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-vfs.git
> --branch <https://gitbox.apache.org/repos/asf/commons-vfs.git--branch>
> commons-vfs-2.10.0-RC1 commons-vfs-2.10.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1702/org/apache/commons/commons-vfs2-project/2.10.0/
>
> These are the artifacts and their hashes:
>
> ${commons.sha512list}
>
>
> I have tested this with:
>
> mvn
>
> and
>
> mvn -V -Prelease -Ptest-deploy clean install -DskipTests && \
> mvn -V -Prelease -Ptest-deploy -P japicmp -P jacoco site deploy
> -DskipTests && \
> mvn -V -Prelease -Ptest-deploy site:stage
>
> Details of changes since 2.9.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/index.html
> (note some *relative* links are broken and the 2.10.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 2.9.0):
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2/japicmp.html
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2-ant/japicmp.html
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2-hdfs/japicmp.html
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2-jackrabbit1/japicmp.html
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2-jackrabbit2/japicmp.html
>
> Note that per the Java Language Specification, "Changes to the
> throws clause of methods or constructors do not break compatibility
> with pre-existing binaries; these clauses are checked only at compile
> time."; see
> https://docs.oracle.com/javase/specs/jls/se21/html/jls-13.html#jls-13.4.21
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/rat-report.html
>
> KEYS:
> https://downloads.apache.org/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1a) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-vfs.git --branch
> commons-vfs-2.10.0-RC1 commons-vfs-2.10.0-RC1
> cd commons-vfs-2.10.0-RC1
>
> 1b) Download and unpack the source archive from:
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/source
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which
> you then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page
> which you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page
> which you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE
> reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of
> packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> 6) Build the site for a multi-module project
>
> mvn site
> mvn site:stage
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> Note that the project reports are created for each module.
> Modules can be accessed using the 'Project Modules' link under
> the 'Project Information' menu (see <path-to-site>/modules.html).
>
> -the end-
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
