+1 Elliotte ...plus the fact [io] is optional in the pom too which is not correct.
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le jeu. 22 févr. 2024 à 14:44, Elliotte Rusty Harold <elh...@ibiblio.org> a écrit : > Looks like this was fixed at head a few days ago by using Charsets > from commons-io instead of commons-codec, and will be in 1.26.1. That > said, I don't really like the fix that was committed. The use of the > Charsets class here is trivial and should simply be inlined. It's not > sufficient reason to pull in an external Charsets class from either > commons-codec or commons-io. > > On Thu, Feb 22, 2024 at 7:08 AM Andrew Coates <big.andy.coa...@gmail.com> > wrote: > > > > Hi all, > > > > I'm seeing a runtime failure using TarArchiveOutputStream when updating > to > > commons-compress 1.26.0. > > > > java.lang.NoClassDefFoundError: org/apache/commons/codec/Charsets > > at org.apache.commons.compress@1.26.0 > > > /org.apache.commons.compress.archivers.tar.TarArchiveOutputStream.<init>(TarArchiveOutputStream.java:212) > > at org.apache.commons.compress@1.26.0 > > > /org.apache.commons.compress.archivers.tar.TarArchiveOutputStream.<init>(TarArchiveOutputStream.java:157) > > at org.apache.commons.compress@1.26.0 > > > /org.apache.commons.compress.archivers.tar.TarArchiveOutputStream.<init>(TarArchiveOutputStream.java:147) > > at testcontainers@1.19.5 > > > /org.testcontainers.containers.ContainerState.copyFileToContainer(ContainerState.java:350) > > ... > > > > Commons-compress 1.26.0 contains changes to make use of commons-codec, > > rather than its own copy of files, but I see that the POM marks > > commons-codec as *optional*. Excuse my potential ignorance, but I thought > > optional dependencies shouldn't cause runtime failures if not present. > Is > > this not the case? > > > > Obviously, I can just add commons-codec as an explicit dependency. But > this > > seems wrong IMHO. > > > > Should I sign up for an account and raise this as a bug in Jira? > > > > Thanks, > > > > Andy > > > > -- > Elliotte Rusty Harold > elh...@ibiblio.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
