You can always test the java version and adjust the asserts but, without
being a [text] expert, I assume the toString usage will create more
troubles than helping so can need to be dropped or totally embraced in the
main impl.
Another option is to request if the JDK dev want to fix it since it as a
lot of side effects - thinking to API - so it can be something they come
back on.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le dim. 15 oct. 2023 à 21:42, Gary Gregory <garydgreg...@gmail.com> a
écrit :

> Good find Roman, that suspiciously looks like the culprit and causes a
> mismatch with the tests use of DecimalFormatter.
>
> Do you see a way to make the test take this into account?
>
> Ty,
> Gary
>
>
> On Sun, Oct 15, 2023, 2:13 PM Romain Manni-Bucau <rmannibu...@gmail.com>
> wrote:
>
> > Hi Gary,
> >
> > Can't it be
> >
> >
> https://github.com/openjdk/jdk/commit/fb605944b5b734c8b47a9122e7ab3d3dcf55f71e
> > ?
> >
> > Long story short, commons-text uses Double.toString which changed due to
> > double (resp float) precision so it impacts tests.
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le dim. 15 oct. 2023 à 19:57, Gary Gregory <garydgreg...@gmail.com> a
> > écrit :
> >
> > > Hi all,
> > >
> > > Can someone explain the 1 test failure on Java 21 in DoubleFornatTest?
> A
> > > one digit difference?
> > >
> > > Gary
> > >
> >
>

Reply via email to