This lazy vote passes with one binding +1 from Gary Gregory (me) and comments from Alex Herbert and sebb.
Gary On Thu, Oct 5, 2023 at 8:28 AM Gary Gregory <garydgreg...@gmail.com> wrote: > > I've not tried to dig into that one. Maybe running with -X will be > revealing... > > Gary > > On Mon, Oct 2, 2023 at 4:58 PM sebb <seb...@gmail.com> wrote: > > > > I get the following warnings on the parent pom with Java 11+: > > > > $ mvn clean install > > [WARNING] Unknown keyword additionalItems - you should define your own > > Meta Schema. If the keyword is irrelevant for validation, just use a > > NonValidationKeyword > > [INFO] attaching as commons-parent-63-SNAPSHOT-cyclonedx.json > > [INFO] > > [INFO] --- spdx-maven-plugin:0.7.0:createSPDX (build-sbom-spdx) @ > > commons-parent --- > > [INFO] spdx file type = .json > > [INFO] Creating SPDX File > > /private/var/sebb/git/commons/parent/target/site/org.apache.commons_commons-parent-63-SNAPSHOT.spdx.json > > [WARNING] Unable to map maven licenses to a declared license. Using > > NOASSERTION > > [WARNING] Null package file > > > > On Mon, 2 Oct 2023 at 14:20, Gary Gregory <garydgreg...@gmail.com> wrote: > > > > > > I plan on eventually having all configs for checkstyle, spotbugs and so on > > > under the same dir in each component such that each component is not > > > forced > > > to declare checkstyle, spotbugs and so on. > > > > > > Gary > > > > > > > > > On Mon, Oct 2, 2023, 9:05 AM Alex Herbert <alex.d.herb...@gmail.com> > > > wrote: > > > > > > > Can you provide the usage for the new <commons.conf.dir> property? > > > > This is listed in the release notes as a new feature thanks to > > > > dependabot. But the commit was a single line added by Gary. I do not > > > > think it is attributed to dependabot. It is added under the release > > > > management section for properties for the Commons Release plugin but I > > > > cannot find 'commons.conf.dir' referenced in the current release > > > > plugin code. > > > > > > > > Alex > > > > > > > > On Mon, 2 Oct 2023 at 13:28, Gary Gregory <garydgreg...@gmail.com> > > > > wrote: > > > > > > > > > > We have fixed a few bugs and added some enhancements since Apache > > > > > Commons Parent 62 was released, so I would like to release Apache > > > > > Commons Parent 63. > > > > > > > > > > Apache Commons Parent 63 RC2 is available for review here: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/63-RC2 > > > > > (svn revision 64292) > > > > > > > > > > The Git tag commons-parent-63-RC2 commit for this RC is > > > > > cf512e1352e886a50c1f292420dbc052bdedbf39 which you can browse here: > > > > > > > > > https://gitbox.apache.org/repos/asf?p=commons-parent.git;a=commit;h=cf512e1352e886a50c1f292420dbc052bdedbf39 > > > > > You may checkout this tag using: > > > > > git clone https://gitbox.apache.org/repos/asf/commons-parent.git > > > > > --branch commons-parent-63-RC2 commons-parent-63-RC2 > > > > > > > > > > Maven artifacts are here: > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1662/org/apache/commons/commons-parent/63/ > > > > > > > > > > These are the artifacts and their hashes: > > > > > > > > > > #Release SHA-512s > > > > > #Mon Oct 02 07:53:04 EDT 2023 > > > > > > > > > commons-parent-63-src.tar.gz=415919a83c9a84101c586e36da25aeacad9126119e5f3bee1de8db8e4dbda46c5b0a28a0c440ea64254533f31d31be5e2904838e1dd72d456e7befde7a6b2f77 > > > > > > > > > org.apache.commons_commons-parent-63.spdx.json=51ef87a005d61ad1aa1318770ad79f4decbe717d7a570266c3ad24223fe5f7e7fcaf0ef162a5e6dc232ba6f79799f484ce68345a8bf164bf52f6992bf6d5cc7c > > > > > > > > > commons-parent-63-site.xml=5f045989b2c281c567467548678fe8685efabf5c13104299eea87b6ab6b6a75c9e98b590d7b288b8ec3a06934061709d0851a6dd9d9b45100ee2950908ec2d6c > > > > > > > > > commons-parent-63-src.zip=3674e727c8a770117d40d21812d581774446d9144a9625d3b45535231ccc9ad7e923397d1e9df16133888fbcc8745c573639f89523ba3dd360d459d08069eea1 > > > > > > > > > commons-parent-63-bom.json=d08fbea2168dcd027d6c2928c3604f22b081d4d88fd480f1f2b282c3ac32a15f312e47e72ad0d0f525680e931d311fe51472e9b6450e2bde5ee1a3f4632aaad2 > > > > > > > > > commons-parent-63-bom.xml=36d3cb1aed436d44fbb97ef16e1e603196598dea68cc113ebfe630c7044a214132c6e7444f32f4e90ba8bf5d47f357d3426afa37b4ea6a8e735ddd666e8d0744 > > > > > > > > > > I have tested this with: > > > > > > > > > > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site > > > > deploy > > > > > > > > > > using: > > > > > > > > > > Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) > > > > > Maven home: /usr/local/Cellar/maven/3.9.4/libexec > > > > > Java version: 17.0.8.1, vendor: Homebrew, runtime: > > > > > /usr/local/Cellar/openjdk@17/17.0.8.1/libexec/openjdk.jdk/Contents/Home > > > > > Default locale: en_US, platform encoding: UTF-8 > > > > > OS name: "mac os x", version: "14.0", arch: "x86_64", family: "mac" > > > > > > > > > > Darwin **** 23.0.0 Darwin Kernel Version 23.0.0: Fri Sep 15 14:42:42 > > > > > PDT 2023; root:xnu-10002.1.13~1/RELEASE_X86_64 x86_64 > > > > > > > > > > Details of changes since 62 are in the release notes: > > > > > > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/63-RC2/RELEASE-NOTES.txt > > > > > > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/63-RC2/site/changes-report.html > > > > > > > > > > Site: > > > > > > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/63-RC2/site/index.html > > > > > (note some *relative* links are broken and the 63 directories are > > > > > not yet created - these will be OK once the site is deployed.) > > > > > > > > > > RAT Report: > > > > > > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/63-RC2/site/rat-report.html > > > > > > > > > > KEYS: > > > > > https://downloads.apache.org/commons/KEYS > > > > > > > > > > Please review the release candidate and vote. > > > > > This vote will close no sooner than 72 hours from now. > > > > > > > > > > [ ] +1 Release these artifacts > > > > > [ ] +0 OK, but... > > > > > [ ] -0 OK, but really should fix... > > > > > [ ] -1 I oppose this release because... > > > > > > > > > > Thank you, > > > > > > > > > > garydgregory, > > > > > Release Manager (using key DEADBEEF) > > > > > > > > > > For following is intended as a helper and refresher for reviewers. > > > > > > > > > > Validating a release candidate > > > > > ============================== > > > > > > > > > > These guidelines are NOT complete. > > > > > > > > > > Requirements: Git, Java, Maven. > > > > > > > > > > You can validate a release from a release candidate (RC) tag as > > > > > follows. > > > > > > > > > > 1a) Clone and checkout the RC tag > > > > > > > > > > git clone https://gitbox.apache.org/repos/asf/commons-parent.git > > > > > --branch commons-parent-63-RC2 commons-parent-63-RC2 > > > > > cd commons-parent-63-RC2 > > > > > > > > > > 1b) Download and unpack the source archive from: > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/63-RC2/source > > > > > > > > > > 2) Check Apache licenses > > > > > > > > > > This step is not required if the site includes a RAT report page which > > > > > you then must check. > > > > > > > > > > mvn apache-rat:check > > > > > > > > > > 3) Check binary compatibility > > > > > > > > > > Older components still use Apache Clirr: > > > > > > > > > > This step is not required if the site includes a Clirr report page > > > > > which you then must check. > > > > > > > > > > mvn clirr:check > > > > > > > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > > > > > > > This step is not required if the site includes a JApiCmp report page > > > > > which you then must check. > > > > > > > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > > > > > > > 4) Build the package > > > > > > > > > > mvn -V clean package > > > > > > > > > > You can record the Maven and Java version produced by -V in your VOTE > > > > reply. > > > > > To gather OS information from a command line: > > > > > Windows: ver > > > > > Linux: uname -a > > > > > > > > > > 5) Build the site for a single module project > > > > > > > > > > Note: Some plugins require the components to be installed instead of > > > > packaged. > > > > > > > > > > mvn site > > > > > Check the site reports in: > > > > > - Windows: target\site\index.html > > > > > - Linux: target/site/index.html > > > > > > > > > > -the end- > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
