Hello, On Wed, Sep 13, 2023 at 5:57 PM Mark Fortner <phidia...@gmail.com> wrote: > > I was looking at the VFS code recently and had a few questions: > > - There's a *plugins.xml* file that each of the plugins needs to > register themselves with. I was wondering if there was a reason that the > *ServiceLoader* wasn't used for this? It would seem like a natural fit.
VFS was created before service loaders and never migrated. Migrating to service loaders might create compatibility issues, maybe with class loaders, who knows... > - Are there any plans to create adaptors for the NIO FS package? Yes, I have a branch for that in my private repo. It's on my to-do list for sure. > I'm > envisioning something where we write adapters that adapt the interfaces of > one to the interfaces of the other. This might cut down on the amount of > work, since every implementation would not have to write their own NIO FS > adapter. > - Is there a TCK for VFS? Yes, kind of, the unit tests are built within their own testing mini-framework, it's not great but it's what we have. It desperately needs porting from it's JUnit 3 roots to JUnit 5. >This would make it easy for implementers to > verify that they're conforming with the intent of the interfaces. This came > up while I was looking over the S3 implementation and realised that the > UserAuthenticator doesn't seem to be implemented. And that credentials are > basically part of the URL. Ideally, the TCK would allow the user to specify > a ROOT URL, and user credentials, and then run the suite of tests and > verify that all operations work properly. > - What is the long-term plan for VFS? My plan is: - port unit tests to JUnit 5 - interoperation with NIO - modularize such that each file system is in its own Maven module > Do you want to have all of the > implementations be NIO FS implementations, and the original APIs for VFS > would be deprecated? No. If you like the VFS API, you should be able to keep on using it. > The reason I ask is that we have an application that > currently uses VFS with a handful of plugins and want to know if we should > plan on refactoring that at some point to NIO FS? The above said, once NIO is supported, people can decide which they like best and we'll see what kind of feedback we get. HTH, Gary > > > Cheers, > > Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
