Built from src zip using:

mvn install site

Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
Maven home: /Users/ah403/mvn/mvn
Java version: 17.0.6, vendor: Eclipse Adoptium, runtime:
/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "13.3.1", arch: "aarch64", family: "mac"

I see 51 javadoc errors. Some are for private fields. But there are
many for public Builder and 12 for empty <p> tag (most probably using
<p> instead of </p>).

I see some coverage checks failing:

[WARNING] Rule violated for bundle commons-io: classes covered ratio
is 0.97, but expected minimum is 1.00
[WARNING] Rule violated for bundle commons-io: instructions covered
ratio is 0.88, but expected minimum is 0.90
[WARNING] Rule violated for bundle commons-io: methods covered ratio
is 0.89, but expected minimum is 0.95
[WARNING] Rule violated for bundle commons-io: branches covered ratio
is 0.81, but expected minimum is 0.85
[WARNING] Rule violated for bundle commons-io: lines covered ratio is
0.87, but expected minimum is 0.90
[WARNING] Rule violated for bundle commons-io: complexity covered
ratio is 0.83, but expected minimum is 0.85

These numbers (instructions covered; branche covered) are lower than
those reported on the live site report for 2.11. However the CodeCov
report [1] shows the same coverage since the start of reporting
(unfortunately just back to Apr 24) so this may be only a small
downward trend since the last release.

I believe all concerns with the new Builder for streams API were
addressed since the RC1 (I've been following the commits but did not
do a code deep dive). So these are all minor issues.

+1

Alex

[1] https://app.codecov.io/gh/apache/commons-io?search=&trend=30%20days

On Sat, 13 May 2023 at 16:24, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons IO 2.11.0 was released, so I would like to
> release Apache Commons IO 2.12.0.
>
> Apache Commons IO 2.12.0 RC2 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/io/2.12.0-RC2 (svn
> revision 61825)
>
> The Git tag commons-io-2.12.0-RC2 commit for this RC is
> 266bcc4d5d0fbd230756539f93acd9fc5ddd2c5c which you can browse here:
>     
> https://gitbox.apache.org/repos/asf?p=commons-io.git;a=commit;h=266bcc4d5d0fbd230756539f93acd9fc5ddd2c5c
> You may checkout this tag using:
>     git clone https://gitbox.apache.org/repos/asf/commons-io.git
> --branch commons-io-2.12.0-RC2 commons-io-2.12.0-RC2
>
> Maven artifacts are here:
>     
> https://repository.apache.org/content/repositories/orgapachecommons-1635/commons-io/commons-io/2.12.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat May 13 11:10:37 EDT 2023
> commons-io-2.12.0-bin.tar.gz=24e41dec5dbdbd56d24c3d2ff294a1fecd4d0a80f1af2821ecf60da3527774aced1dca8d0752cebf444249cc4a207baf0fd6555e463b45879e02d0f03acc2445
> commons-io-2.12.0-bin.zip=03c1b6394a07b7b7ed36c97191891811985df9e89ce7369ac7e69d83e6491cc288755d33936ba45cb57fdac5addadf4b19b183b8f2ae52a0e1ee78157c80ea8d
> commons-io-2.12.0-bom.json=07c0b0c4112f54573606a7346699930850fef1274e848576c4a458edbcdd8b613c2cd6d54ab5f96a82a91875e8bbec41f9d50296dfea8558dd317c0ea0555b12
> commons-io-2.12.0-bom.xml=6fb6f96277ef2703bcb5d589bb6fdd1e7f8157d412ace264eb7a47ef0e245d9afa9ebf2b15b4e04b25fb600b37f6369a203ff90b33b904fd3869e48dc0a62069
> commons-io-2.12.0-javadoc.jar=af7ac2ef5439a3d744625917df048445ca6c867c8bef823d70f67a3c3509373b0f70dd4f37e1dd6b1e9ea9878d3a8596262f085ceb8f5255e5af868a9a19d231
> commons-io-2.12.0-sources.jar=a43e070c8b9f4b9a23bb3a6dd9bb5970d0bc8bc973e7fac707d35ac561738e785fffa92acca91483465539a3083fc36431ec09582fa0f98299848e795ff87ce2
> commons-io-2.12.0-src.tar.gz=0318e1566ed125a1d10a0a4f72895c0e7f0b1ad4f8704caec3a107b1755edaef6cd7502eb367c3b2b95e5ec46990b29c90e06cfe4da1cddd13cb9026bb5dee3a
> commons-io-2.12.0-src.zip=df6476b8a9b44746d71a617733048b1848612ec894564d413d92bc16426fe65a38cfbaa12c02140f76668220d9223f9e7d3c5b9a4c793fe14aff38540e0dd91a
> commons-io-2.12.0-test-sources.jar=594d19d76ab22e184fc962a4a3e4c91ff10e097cb5a8a52345a23b3b6d85e824f4844757d5c54f9d4d52a6e62687082d3685295f535d227b7a9586ea2444690b
> commons-io-2.12.0-tests.jar=86e392706ff98f04d053c4b3bbf1df5bb7a375f5ebcb1673ecdbedab36db627723937c93a6559944c19b516ce3b0f83d50143512dd2b891a1cc22524ee28c401
> commons-io_commons-io-2.12.0.spdx.json=071b3e127e1027587db04af620c406fd32ebb9810bd75936fd33131782b0c89417d83672f8ede5302eada044b4a2572b5dfbc598ca70a71695cad6fdea62d25a
>
> I have tested this with:
>
> mvn -V -Duser.name=$my_apache_id -Prelease -Ptest-deploy -P jacoco -P
> japicmp clean package site deploy
>
> Using:
>
> Apache Maven 3.9.2 (c9616018c7a021c1c39be70fb2843d6f5f9b8a1c)
> Maven home: /usr/local/Cellar/maven/3.9.2/libexec
> Java version: 1.8.0_372, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@8/1.8.0+372/libexec/openjdk.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "13.3.1", arch: "x86_64", family: "mac"
>
> Darwin **** 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar  6 21:00:17
> PST 2023; root:xnu-8796.101.5~3/RELEASE_X86_64 x86_64
>
> Details of changes since 2.11.0 are in the release notes:
>     
> https://dist.apache.org/repos/dist/dev/commons/io/2.12.0-RC2/RELEASE-NOTES.txt
>     
> https://dist.apache.org/repos/dist/dev/commons/io/2.12.0-RC2/site/changes-report.html
>
> Site:
>     
> https://dist.apache.org/repos/dist/dev/commons/io/2.12.0-RC2/site/index.html
>     (note some *relative* links are broken and the 2.12.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 2.11.0):
>     
> https://dist.apache.org/repos/dist/dev/commons/io/2.12.0-RC2/site/japicmp.html
>
> RAT Report:
>     
> https://dist.apache.org/repos/dist/dev/commons/io/2.12.0-RC2/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-io.git --branch
> commons-io-2.12.0-RC2 commons-io-2.12.0-RC2
> cd commons-io-2.12.0-RC2
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which
> you then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page
> which you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page
> which you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to