On Sun, 4 Dec 2022 at 22:32, Gilles Sadowski <gillese...@gmail.com> wrote: > > Hello. > > Many thanks for taking care of the release(s). > > Le jeu. 1 déc. 2022 à 18:32, Alex Herbert <aherb...@apache.org> a écrit : > > > > I would like to release Apache Commons Statistics 1.0. > > > > Apache Commons Statistics 1.0 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/statistics/1.0-RC1 > > (svn revision 58393) > > > > The Git tag commons-statistics-1.0-RC1 commit for this RC is > > commons-statistics-1.0-RC1 which you can browse here: > > > > https://gitbox.apache.org/repos/asf?p=commons-statistics.git;a=commit;h=commons-statistics-1.0-RC1 > > This looks fine ("<version>1.0</version>"), but in the > 1.0-release > branch, the "pom.xml" contains > 1.0-SNAPSHOT
Strange. I do not see that locally. git clone https://gitbox.apache.org/repos/asf/commons-statistics cd commons-statistics/ git checkout 1.0-release git grep SNAPSHOT This only finds SNAPSHOT in the release.howto.txt. The 1.0-release branch is currently sitting at the same commit as the 1.0-RC1 tag: git log -1 commit 37c9488d9e75ce23b30f2282cc8621ac19afa43c (HEAD -> 1.0-release, tag: commons-statistics-1.0-RC1, origin/1.0-release) Author: aherbert <aherb...@apache.org> Date: Wed Nov 30 14:58:53 2022 +0000 git commit -m "Release candidate." > > > > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-statistics.git > > --branch commons-statistics-1.0-RC1 commons-statistics-1.0-RC1 > > > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/orgapachecommons-1609/org/apache/commons/ > > Do we note somewhere what are the files whose names end with > spdx.rdf.xml > (their purpose and how to use them)? In short, no. Perhaps a page on commons-site somewhere would be useful. These come from CP 54. There is no <skip> property for the SPDX plugin. But it does not fail the build like the cyclonedx plugin also introduced for artifact metadata in CP 54. I had to disable that one. You can disable the SPDX plugin using an invalid phase which I did in the RNG BOM to simplify the build for that artifact: https://github.com/apache/commons-rng/blob/9684d3992904ca51188d4491e164a0545f4f2126/commons-rng-bom/pom.xml#L82 More info: https://github.com/spdx/spdx-maven-plugin I do not know much about how to use this metadata. But all projects using CP 54+ will be publishing this artifact now. What I notice is that the SPDX plugin is quite noisy in the maven build, has some errors about licenses (which looking at their documentation it should support the ASF 2.0 license with the defaults), and I think it may cause some phases in the build to repeat as it scans artifact dependencies. I'd have to fully trace the phases and plugin executions to verify that one. > > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Thu Dec 01 16:46:47 GMT 2022 > > commons-statistics-1.0-bin.tar.gz=6a3cf6768e6d8c28992566811efa176bad78c74a587ef5420748fb913ece7dec85c459fd7dd72e0fc53a35b18d1b8b1a78e93a8a029f4ce78adc5038b3a6216f > > commons-statistics-1.0-bin.zip=28d0475cbf638c9776f62991f5428abebc43ee61de94e1cf4d92ea90a9034fff08d6af11297194ac70ad045c9955a04b8bc20729e02d6797a7a3a1e786ecd1b6 > > commons-statistics-1.0-src.tar.gz=008484a1b0302d6fcbd221b21cfc78fb47b401749991a6ecf951996a86c86a8595f51aaa9e125ca611cc236d7b5107e0a2ed85d55e39420afade475f6e49a012 > > commons-statistics-1.0-src.zip=c012c44d02a6210beb53d7ca5efd577704cdf34851af862d301c454683eecebe716ef46932d843292dc772147d068b142126dd5450623e640fd2c550f979ad76 > > OK. > > > > > I have tested this with 'mvn clean install site site:stage -Pexamples' > > using: > > > > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > > Maven home: /usr/local/apache-maven-3 > > Java version: 1.8.0_352, vendor: Private Build, runtime: > > /usr/lib/jvm/java-8-openjdk-amd64/jre > > Default locale: en_GB, platform encoding: UTF-8 > > OS name: "linux", version: "4.15.0-197-generic", arch: "amd64", family: > > "unix" > > Build successful. Command was > $ mvn clean package site site:stage -Pexamples > > $ mvn -v > Apache Maven 3.6.3 > Maven home: /usr/share/maven > Java version: 11.0.16, vendor: Debian, runtime: > /usr/lib/jvm/java-11-openjdk-amd64 > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.10.0-17-amd64", arch: "amd64", family: "unix" > > > > > Release notes: > > > > https://dist.apache.org/repos/dist/dev/commons/statistics/1.0-RC1/RELEASE-NOTES.txt > > Contains the line: > ---CUT--- > Download page: > https://commons.apache.org/proper/commons-statistics/download_text.cgi > ---CUT--- Thanks. I copied the newer Velocity template from Lang/Text. I missed this change (by only correcting part of the URL). It should be: https://commons.apache.org/proper/commons-statistics/download_statistics.cgi I'll wait to see if any other reviews find issues. It is not a blocker but would be nice to correct. I am wondering why the module page on the site I uploaded does not render correctly. It is this one: https://home.apache.org/~aherbert/commons-statistics-1.0-RC1-site/commons-statistics-distribution/index.html Locally it looks fine (prettyprint is enabled for the source, the statistics logo is small). When I use the web version the prettyprint does not work and the logo is too big. Do you see this issue? I also had similar issues with the RNG 1.5 site when hosted on home.apache.org that did not occur on the proper dist web area. So it may be some set-up with the home.apache.org host that is different. Alex --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
