Thanks Alex.
I'll see what I can clean up this weekend before RC2 unless someone else can
get to it.
Gary
On 2022/10/26 16:31:00 Alex Herbert wrote:
> Validated signatures on the binary and src distributions.
>
> Built from src.zip using:
>
> maven install site -P jacoco -P japicmp
>
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /usr/local/apache-maven-3
> Java version: 11.0.16, vendor: Ubuntu, runtime:
> /usr/lib/jvm/java-11-openjdk-amd64
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-194-generic", arch: "amd64", family: "unix"
>
> I received a NullPointerException from the Jira report:
>
> [INFO] Generating "JIRA Report" report ---
> maven-changes-plugin:2.12.1:jira-report
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.apache.cxf.transport.http.CXFAuthenticator
> (file:/home/ah403/.m2/repository/org/apache/cxf/
> cxf-rt-transports-http/2.6.3/cxf-rt-transports-http-2.6.3.jar) to
> field java.net.Authenticator.theAuthenticator
> WARNING: Please consider reporting this to the maintainers of
> org.apache.cxf.transport.http.CXFAuthenticator
> WARNING: Use --illegal-access=warn to enable warnings of further
> illegal reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> [WARNING]
> java.lang.NullPointerException
> at org.apache.maven.plugin.jira.RestJiraDownloader.processPriority
> (RestJiraDownloader.java:392)
> at org.apache.maven.plugin.jira.RestJiraDownloader.buildIssues
> (RestJiraDownloader.java:329)
> at org.apache.maven.plugin.jira.RestJiraDownloader.doExecute
> (RestJiraDownloader.java:172)
>
> The same build using Java 8 also had the same error using:
>
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /usr/local/apache-maven-3
> Java version: 1.8.0_333, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/jdk1.8.0_333/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-194-generic", arch: "amd64", family: "unix"
>
> I checked your site build in the SVN staging repo and that also does
> not have a Jira report.
>
> There is one skipped test for BCEL-291. The Jira ticket is marked as
> fix version 6.6.0; the ticket is reopened. Perhaps the fix version
> should be updated as it has not yet been fixed.
>
> There are a few PMD items to easily clean up. Empty catch blocks can
> use 'catch(Exception ignored) {'. There are some redundant final
> keywords to remove. Can be done post release.
>
> All other reports are OK. Some Spotbugs issues but they have been
> around for a while.
>
> So this seems OK except the broken Jira report. I don't think this is
> a blocker given that the live site for 6.6.0 also has no Jira report.
> I cannot see anything custom in the pom to configure the jira report.
> The exception stack trace is at method processPriority. So perhaps
> there is a ticket with an unusual priority. I see some tickets where
> there is an additional priority field with P1, P2, P3 as well as the
> usual priority field with major, minor, etc (see BCEL-183 [1]). There
> is nothing in commons parent configuring priority so it could be a
> loss leader. When you search for issues in BCEL using e.g. 'project =
> BCEL AND priority = P2' it finds no tickets, so this extra field is
> not searchable. There is something broken with the Jira project for
> BCEL. Fixing that is outside the scope of the release.
>
> +1
>
> Alex
>
> [1] https://issues.apache.org/jira/browse/BCEL-183
>
> On Sun, 23 Oct 2022 at 15:58, Gary Gregory <garydgreg...@gmail.com> wrote:
> >
> > We have fixed one bug since Apache Commons BCEL 6.6.0 was released, so
> > I would like to release Apache Commons BCEL 6.6.1. This will help
> > SpotBugs migrate from 6.5.0.
> >
> > Apache Commons BCEL 6.6.1 RC1 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1 (svn
> > revision 57519)
> >
> > The Git tag commons-bcel-6.6.1-RC1 commit for this RC is
> > ec208052baf4c596f7e8cfacc281d3e2408809ac which you can browse here:
> >
> > https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=ec208052baf4c596f7e8cfacc281d3e2408809ac
> > You may checkout this tag using:
> > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> > --branch commons-bcel-6.6.1-RC1 commons-bcel-6.6.1-RC1
> >
> > Maven artifacts are here:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-1602/org/apache/bcel/bcel/6.6.1/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Sun Oct 23 10:44:36 EDT 2022
> > Apache\ Commons\
> > BCEL-6.6.1.spdx.rdf.xml=f07a9526a013c6c700e84005f45eb3f582b105756486b665b084be1accf147179e22db752c370dd2cf2c779a2c9188b2fec431fc7de56f0cfc355c26ea25d2fe
> > bcel-6.6.1-bin.tar.gz=4358ab0a7103e33bf4d0774cdeab11c4b32a7ef65944e08602b6a5c2da7ac1e8f04edc1603b458381e29c9341c32f1679521bb544eb4a081c351d82b646d6024
> > bcel-6.6.1-bin.zip=1acd0c776c06d50e7f2a4c5d6f7ea90374cdb9f0d6ddc994eb5d8a6eb3632ac10327167b372567456b0b83c0ebd99652f0f69c39e3ba57d31b87b32063eb223d
> > bcel-6.6.1-bom.json=e51e003589f1de2e73d1fbc3dfdff6f30e85df2aca036b9bcdf5dffe5eb6915adbbb8ab72aed63ff5dcd32b9db51316a088c2b89e8ad54657170c21feae404a8
> > bcel-6.6.1-bom.xml=f00ddbf5a93d88209e781a71de7067897005e36ca88d5be10f105af87f8ae7cabe07e6373f166def2de4c7d72b30e25e8f20a6f17827260754ed870480647049
> > bcel-6.6.1-javadoc.jar=35d2dc3daaa7adefd17561f4dc896dbdce5fb0530c8d867fc8178bdab8c9d21afd27b4429b9650281d8692a62039739795b642e9ff5c317a73b1089661aab491
> > bcel-6.6.1-sources.jar=3ecf109550cd8837dba586570e33c73fa81efccc69e2b68cc03b53756947e4c9f95575e77b751181cf934f20f5e078654f343400b8184ab414e89b316f7f33f4
> > bcel-6.6.1-src.tar.gz=bb4283d1ebcdeaef7f3530826f16681cad7a53508056178d63621f7a17321df3bbc11914e75dd7b81f967723c8b6bc4009853dc80bb4707de2f5f6db26eb8f7a
> > bcel-6.6.1-src.zip=a62790a65ecb2f69f260f683d9f75a3a4ef98abfbec5a37efbe10ad7d5fd9c33771ff5cba305c3f18c336f8495a1ce5c5ab43ecb9124973e2728742d634b6288
> > bcel-6.6.1-test-sources.jar=0f4dd1c7652b564b1343cc2731118c3575d351022f2811d3049f9eccda77b9fb05779691996ddb6396717fa75699e8a407f5c654bf75d5a7aca50bd1a2e9d95f
> > bcel-6.6.1-tests.jar=1a06e51f00d8de83c4128ddfaf3a318a2afca8e5e67739cfb05956d4c4fce02028d3a93ca3288fc494b46ca08d6e707544b5cc5401c12396cde4a0dc25d49136
> >
> > I have tested this with 'mvn' (the default goal) and 'mvn -V
> > -Duser.name=$my_apache_id -Prelease -Ptest-deploy -P jacoco -P japicmp
> > clean package site deploy' using:
> >
> > Darwin **** 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10
> > PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64
> > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> > Maven home: /usr/local/Cellar/maven/3.8.6/libexec
> > Java version: 1.8.0_345, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk@8/1.8.0+345/libexec/openjdk.jdk/Contents/Home/jre
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "12.6", arch: "x86_64", family: "mac"
> >
> > Details of changes since 6.6.0 are in the release notes:
> >
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/RELEASE-NOTES.txt
> >
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/site/changes-report.html
> >
> > Site:
> >
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/site/index.html
> > (note some *relative* links are broken and the 6.6.1 directories
> > are not yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 6.6.0):
> >
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/site/japicmp.html
> >
> > RAT Report:
> >
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/site/rat-report.html
> >
> > KEYS:
> > https://downloads.apache.org/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner than 72 hours from now.
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thank you,
> >
> > Gary Gregory,
> > Release Manager (using key 86fdc7e2a11262cb)
> >
> > For following is intended as a helper and refresher for reviewers.
> >
> > Validating a release candidate
> > ==============================
> >
> > These guidelines are NOT complete.
> >
> > Requirements: Git, Java, Maven.
> >
> > You can validate a release from a release candidate (RC) tag as follows.
> >
> > 1) Clone and checkout the RC tag
> >
> > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> > --branch commons-bcel-6.6.1-RC1 commons-bcel-6.6.1-RC1
> > cd commons-bcel-6.6.1-RC1
> >
> > 2) Check Apache licenses
> >
> > This step is not required if the site includes a RAT report page which
> > you then must check.
> >
> > mvn apache-rat:check
> >
> > 3) Check binary compatibility
> >
> > Older components still use Apache Clirr:
> >
> > This step is not required if the site includes a Clirr report page
> > which you then must check.
> >
> > mvn clirr:check
> >
> > Newer components use JApiCmp with the japicmp Maven Profile:
> >
> > This step is not required if the site includes a JApiCmp report page
> > which you then must check.
> >
> > mvn install -DskipTests -P japicmp japicmp:cmp
> >
> > 4) Build the package
> >
> > mvn -V clean package
> >
> > You can record the Maven and Java version produced by -V in your VOTE reply.
> > To gather OS information from a command line:
> > Windows: ver
> > Linux: uname -a
> >
> > 5) Build the site for a single module project
> >
> > Note: Some plugins require the components to be installed instead of
> > packaged.
> >
> > mvn site
> > Check the site reports in:
> > - Windows: target\site\index.html
> > - Linux: target/site/index.html
> >
> > -the end-
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
