Thanks Bruno, Good finds! I will fix those issues post release.
Gary On Sat, Oct 8, 2022, 23:55 Bruno Kinoshita <ki...@apache.org> wrote: > [x] +1 Release these artifacts (assuming the changes.xml date can be > fixed later) > > Build passed with no issues, running `mvn clean test install site` on > > Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Maven home: /opt/apache-maven-3.8.5 > Java version: 17.0.4, vendor: Private Build, runtime: > /usr/lib/jvm/java-17-openjdk-amd64 > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.15.0-48-generic", arch: "amd64", family: > "unix" > > The RELEASE-NOTES.txt contains a dangling "TBD." paragraph. I think that > can be removed later? > > https://github.com/apache/commons-bcel/blob/78ecfd5a76ab24e9cb3e5fab6bd4f60187cd6342/RELEASE-NOTES.txt#L16 > > LICENSE file is OK, NOTICE too. The src/changes/changes.xml has the wrong > year though. It's showing 2020 instead of 2022. That may be something that > can be fixed when we deploy the site, I think? > > https://github.com/apache/commons-bcel/blob/78ecfd5a76ab24e9cb3e5fab6bd4f60187cd6342/src/changes/changes.xml#L65 > > Had a look at the dist area archives and found no issues (looked inside a > tar/gz and a zip file in each folder, and checked signatures). > > Thanks Gary! > > Bruno > > > On Sun, 9 Oct 2022 at 01:36, Gary Gregory <garydgreg...@gmail.com> wrote: > > > We have fixed a few bugs and added some enhancements since Apache > > Commons BCEL 6.5.0 was released, so I would like to release Apache > > Commons BCEL 6.6.0. > > > > Apache Commons BCEL 6.6.0 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.0-RC1 (svn > > revision 57228) > > > > The Git tag commons-bcel-6.6.0-RC1 commit for this RC is > > 78ecfd5a76ab24e9cb3e5fab6bd4f60187cd6342 which you can browse here: > > > > > https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=78ecfd5a76ab24e9cb3e5fab6bd4f60187cd6342 > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git > > --branch <https://gitbox.apache.org/repos/asf/commons-bcel.git--branch> > > commons-bcel-6.6.0-RC1 commons-bcel-6.6.0-RC1 > > > > Maven artifacts are here: > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1599/org/apache/bcel/bcel/6.6.0/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Sat Oct 08 08:08:18 EDT 2022 > > Apache\ Commons\ > > > > > BCEL-6.6.0.spdx.rdf.xml=f7124616f821975c0ff263bf7a140d5289255a9411c0455504b031afe274b45690e906eb2e33a2948d2842bdd0dc053ac3ed8610620144b410b6cd40c0292a5e > > > > > bcel-6.6.0-bin.tar.gz=4445555b0f80e8729ba88219ed73aaf79f51f86233dee1213823c9e511392b608b6b64304d161d58d5d8c5070dd976a2a1b26866023b89db4d0883d9325790ab > > > > > bcel-6.6.0-bin.zip=b9652fbe2ff847aae43789cc2fbb3610f48de585f03e022e1251b811931cc86ffb0015295da06c3c129eed67890baf164eb90b41d0f9e0ffc98321c14538de1e > > > > > bcel-6.6.0-bom.json=8e49ec6054792b71b17f17899ee6f73a62ba2748b6aaf2753f01759f52b477dbb4f1894009cc6ca562f40956c8361ad76490dd3f1263d65791ce5ab75b0a8def > > > > > bcel-6.6.0-bom.xml=dde502c23f2573c321ecbc15cebec2f4646f1d0b68e91db9d7ffbe7ec5e840aeb8094d77ddd04898a41bfee96381c219c7721e0cb3b47508bf89de81931d191e > > > > > bcel-6.6.0-javadoc.jar=4efa4c85df233c84262dfc02bb5cd8738e22c31e4bf4979dc17fbe6e9416001e2dc2b87321f89eff5de88da5f977bc52439a2b268865058c8af40d486177aa6e > > > > > bcel-6.6.0-sources.jar=69a677bebb80bce9e87a95d2d97115157613383a096985530ef744780418a62494c6586b5a0b7d82c19919d3edd76de57b4baea87355b5d07d9db925763c7d35 > > > > > bcel-6.6.0-src.tar.gz=13f361be498625c3276860ae14c225c49135687f4ba69de4afaac2d135df4e5c6b51277e3cd4c05bac27156e4fab5316c102a25a67d8abb6c640499917d01917 > > > > > bcel-6.6.0-src.zip=097b26494758f2a4db2f3d91f199cf02d1d8209022e6e93416e54cdcae94f7b0866169db631ad60d9c4c309fba5cf3aec06d7ca88e33486ddca43fe29707984b > > > > > bcel-6.6.0-test-sources.jar=b9d4452afa720afb8bcb944e8b2f12791a2f6e2034ca08d5c19b7f57b44ab4d26e5eedaa36af008e24fc0663adbba3e05d86b88af50bcd6f3aacc4f1bbbc8d56 > > > > > bcel-6.6.0-tests.jar=0221fff1f00d38b0e73f8b25c7fdebfec74ae28936c3b4c52a463a70292a1acc0d027452a38e854d0434673f16c10c0ba69841ad0ce02d1de57d1b5db0c1388e > > > > > > I have tested this with 'mvn -V -Duser.name=$my_apache_id -Prelease > > -Ptest-deploy -P jacoco -P japicmp clean package site deploy' using: > > > > Darwin *** 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10 > > PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64 > > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > > Maven home: /usr/local/Cellar/maven/3.8.6/libexec > > Java version: 1.8.0_345, vendor: Homebrew, runtime: > > /usr/local/Cellar/openjdk@8 > > /1.8.0+345/libexec/openjdk.jdk/Contents/Home/jre > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "mac os x", version: "12.6", arch: "x86_64", family: "mac" > > > > Details of changes since 6.5.0 are in the release notes: > > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.0-RC1/RELEASE-NOTES.txt > > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.0-RC1/site/changes-report.html > > > > Site: > > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.0-RC1/site/index.html > > (note some *relative* links are broken and the 6.6.0 directories > > are not yet created - these will be OK once the site is deployed.) > > > > JApiCmp Report (compared to 6.5.0): > > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.0-RC1/site/japicmp.html > > > > RAT Report: > > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.0-RC1/site/rat-report.html > > > > KEYS: > > https://downloads.apache.org/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > For following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1) Clone and checkout the RC tag > > > > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git > > --branch commons-bcel-6.6.0-RC1 commons-bcel-6.6.0-RC1 > > cd commons-bcel-6.6.0-RC1 > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > > you then must check. > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > This step is not required if the site includes a JApiCmp report page > > which you then must check. > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE > > reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > -the end- > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > >
