I've approved the PR, and also set the fixVersion for the next 2.8.0 release.
This change doesn't break binary compatibility, but does change behavior/feature. Users who were - for one reason or another - handling array values, instead of the first value, will have to update their code after this change. But on the other hand, the inconsistency could also be considered a bug by other issues, which would justify including it in the next bugfix or minor release. I'm in favor of releasing it, with an extra note to the release notes and/or Announce email about the change for users. Thanks Matt! -Bruno On Mon, 16 May 2022 at 08:11, Matt Juntunen <matt.a.juntu...@gmail.com> wrote: > Hello, > > I've made a new PR [1] for CONFIGURATION-753 as part of my > preparations for the next release. I'd like to get another pair of > eyes on it if possible since it adds to the public API. The primary > cause of the issue is that DefaultConversionHandler and > ConfigurationInterpolator use different logic when determining how to > convert container objects (e.g., collections and arrays) to strings. > DefaultConversionHandler chooses the first element from the container > and ConfigurationInterpolator just calls toString on the entire > container, resulting in inconsistent string interpolation results. The > change I made is to extract the ConfigurationInterpolator string > conversion logic into a configurable "stringConverter" function that > defaults to behave similarly to DefaultConversionHandler. If this > logic is not what users want, they are free to override it. > > If anyone has time to give feedback on this, it would be much > appreciated, especially since I haven't worked with configuration much > before. > > Regards, > Matt J > > [1] https://github.com/apache/commons-configuration/pull/181 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
